Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kv: minor refactor of conn_and_client #11333

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

asddongmen
Copy link
Contributor

Signed-off-by: dongmen [email protected]

What problem does this PR solve?

Issue Number: ref #10879

What is changed and how it works?

Rename some function and adjust some code structure.

Check List

Tests

  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

@asddongmen asddongmen self-assigned this Jun 21, 2024
@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 21, 2024
Copy link
Contributor

ti-chi-bot bot commented Jun 21, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from asddongmen, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 21, 2024
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 82.29167% with 17 lines in your changes missing coverage. Please review.

Project coverage is 57.6284%. Comparing base (4f7b74c) to head (83b8bc2).
Report is 2 commits behind head on master.

Additional details and impacted files
Components Coverage Δ
cdc 61.4428% <82.2916%> (-0.0047%) ⬇️
dm 51.1950% <ø> (-0.0283%) ⬇️
engine 63.3738% <ø> (ø)
Flag Coverage Δ
unit 57.6284% <82.2916%> (-0.0136%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11333        +/-   ##
================================================
- Coverage   57.6420%   57.6284%   -0.0136%     
================================================
  Files           849        849                
  Lines        126151     126146         -5     
================================================
- Hits          72716      72696        -20     
- Misses        48039      48049        +10     
- Partials       5396       5401         +5     

@asddongmen
Copy link
Contributor Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant