Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s3(ticdc): do not report unretryable error when initializing s3 storage (#11312) #11319

Open
wants to merge 1 commit into
base: release-8.1
Choose a base branch
from
Open

s3(ticdc): do not report unretryable error when initializing s3 storage (#11312) #11319

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/redo/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,12 +202,12 @@
if ConsistentStorage(uri.Scheme) == consistentStorageS3 && len(uri.Host) == 0 {
// TODO: this branch is compatible with previous s3 logic and will be removed
// in the future.
return nil, errors.WrapChangefeedUnretryableErr(errors.ErrStorageInitialize,
return nil, errors.WrapError(errors.ErrStorageInitialize,

Check warning on line 205 in pkg/redo/config.go

View check run for this annotation

Codecov / codecov/patch

pkg/redo/config.go#L205 

Added line #L205 was not covered by tests
errors.Errorf("please specify the bucket for %+v", uri))
}
s, err := util.GetExternalStorageFromURI(ctx, uri.String())
if err != nil {
return nil, errors.WrapChangefeedUnretryableErr(errors.ErrStorageInitialize, err)
return nil, errors.WrapError(errors.ErrStorageInitialize, err)

Check warning on line 210 in pkg/redo/config.go

View check run for this annotation

Codecov / codecov/patch

pkg/redo/config.go#L210 

Added line #L210 was not covered by tests
}
return s, nil
}
Expand Down
Loading