-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
s3(ticdc): do not report unretryable error when initializing s3 storage #11312
s3(ticdc): do not report unretryable error when initializing s3 storage #11312
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: asddongmen, CharlesCheung96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #11312 +/- ##
================================================
- Coverage 57.6547% 57.6139% -0.0409%
================================================
Files 850 850
Lines 126052 126256 +204
================================================
+ Hits 72675 72741 +66
- Misses 47980 48111 +131
- Partials 5397 5404 +7 |
/retest-required |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #11311
What is changed and how it works?
do not report unretryable error when initializing s3 storage, because this kind of error is retryale, return ErrStorageInitialize if the external storage initialization fails.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note