Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s3(ticdc): do not report unretryable error when initializing s3 storage #11312

Merged

Conversation

sdojjy
Copy link
Member

@sdojjy sdojjy commented Jun 14, 2024

What problem does this PR solve?

Issue Number: close #11311

What is changed and how it works?

do not report unretryable error when initializing s3 storage, because this kind of error is retryale, return ErrStorageInitialize if the external storage initialization fails.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 14, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 14, 2024
Copy link
Contributor

ti-chi-bot bot commented Jun 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, CharlesCheung96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CharlesCheung96,asddongmen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 14, 2024
Copy link
Contributor

ti-chi-bot bot commented Jun 14, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-14 03:16:19.465857507 +0000 UTC m=+693733.519169429: ☑️ agreed by CharlesCheung96.
  • 2024-06-14 03:18:40.731173545 +0000 UTC m=+693874.784485469: ☑️ agreed by asddongmen.

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 57.6139%. Comparing base (7dfd11c) to head (9e512e3).
Report is 8 commits behind head on master.

Additional details and impacted files
Components Coverage Δ
cdc 61.4179% <0.0000%> (-0.0808%) ⬇️
dm 51.1748% <ø> (-0.0142%) ⬇️
engine 63.3950% <ø> (-0.0142%) ⬇️
Flag Coverage Δ
unit 57.6139% <0.0000%> (-0.0409%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11312        +/-   ##
================================================
- Coverage   57.6547%   57.6139%   -0.0409%     
================================================
  Files           850        850                
  Lines        126052     126256       +204     
================================================
+ Hits          72675      72741        +66     
- Misses        47980      48111       +131     
- Partials       5397       5404         +7     

@pingcap pingcap deleted a comment from ti-chi-bot bot Jun 14, 2024
@sdojjy
Copy link
Member Author

sdojjy commented Jun 14, 2024

/retest-required

@ti-chi-bot ti-chi-bot bot merged commit 90da67d into pingcap:master Jun 14, 2024
28 checks passed
@sdojjy sdojjy deleted the do-not-report-unretryable-error-when-init-s3 branch June 15, 2024 01:07
@sdojjy sdojjy added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Jun 15, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #11316.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #11317.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #11318.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #11319.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

changefeed task failed after inject s3 network partition last for 10mins
4 participants