Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redo(ticdc): enable pprof and set memory limit for redo applier (#10904) #10994

Open
wants to merge 6 commits into
base: release-7.1
Choose a base branch
from

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #10904

What problem does this PR solve?

Issue Number: close #10900

What is changed and how it works?

  1. Set memory limit for redo applier.
  2. Enable pprof for redo applier to simplify troubleshooting.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

@ti-chi-bot ti-chi-bot added lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Apr 27, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label May 20, 2024
@kennytm
Copy link
Contributor

kennytm commented Aug 30, 2024

/test verify

@kennytm
Copy link
Contributor

kennytm commented Aug 30, 2024

pkg/cmd/redo/apply.go:18:2: G108: Profiling endpoint is automatically exposed on /debug/pprof (gosec)
	_ "net/http/pprof" // init pprof
	^

😒

pkg/cmd/redo/apply.go Outdated Show resolved Hide resolved
Copy link
Contributor

ti-chi-bot bot commented Aug 30, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from charlescheung96, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kennytm
Copy link
Contributor

kennytm commented Aug 30, 2024

/retest

=== FAIL: engine/servermaster TestExecutorManagerWatch (2.00s)
    executor_manager_test.go:184: 
        	Error Trace:	/home/jenkins/agent/workspace/pingcap/tiflow/release-7.1/ghpr_verify/tiflow/engine/servermaster/executor_manager_test.go:184
        	            				/usr/local/go/src/runtime/asm_amd64.s:1598
        	Error:      	Received unexpected error:
        	            	[DFLOW:ErrUnknownExecutor]unknown executor: -8cad396c
        	            	github.com/pingcap/errors.AddStack
        	            		/go/pkg/mod/github.com/pingcap/[email protected]/errors.go:174
        	            	github.com/pingcap/errors.(*Error).GenWithStackByArgs
        	            		/go/pkg/mod/github.com/pingcap/[email protected]/normalize.go:164
        	            	github.com/pingcap/tiflow/engine/servermaster.(*ExecutorManagerImpl).HandleHeartbeat
        	            		/home/jenkins/agent/workspace/pingcap/tiflow/release-7.1/ghpr_verify/tiflow/engine/servermaster/executor_manager.go:136
        	            	github.com/pingcap/tiflow/engine/servermaster.TestExecutorManagerWatch.func4.1
        	            		/home/jenkins/agent/workspace/pingcap/tiflow/release-7.1/ghpr_verify/tiflow/engine/servermaster/executor_manager_test.go:183
        	            	runtime.goexit
        	            		/usr/local/go/src/runtime/asm_amd64.s:1598
        	Test:       	TestExecutorManagerWatch
    executor_manager_test.go:228: 
        	Error Trace:	/home/jenkins/agent/workspace/pingcap/tiflow/release-7.1/ghpr_verify/tiflow/engine/servermaster/executor_manager_test.go:228
        	Error:      	Condition never satisfied
        	Test:       	TestExecutorManagerWatch

Copy link
Contributor

ti-chi-bot bot commented Aug 30, 2024

@ti-chi-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
jenkins-ticdc/verify e6c0d6e link true /test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants