-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sink(ticdc): Add output-old-value config #10915
sink(ticdc): Add output-old-value config #10915
Conversation
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #10915 +/- ##
================================================
+ Coverage 57.3779% 57.4366% +0.0587%
================================================
Files 851 851
Lines 125137 125225 +88
================================================
+ Hits 71801 71925 +124
+ Misses 47944 47901 -43
- Partials 5392 5399 +7 |
/retest-required |
…lue-config # Conflicts: # pkg/sink/codec/open/open_protocol_encoder_test.go
/retest |
/retest-required |
/retest |
@flowbehappy: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3AceShowHand, flowbehappy, hongyunyan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
/retest-required |
2 similar comments
/retest-required |
/retest-required |
/test cdc-integration-kafka-test |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #10916
What is changed and how it works?
this Add
sink.open.output-old-value
for open protocol,sink.debezium.output-old-value
for debezium protocol, the default value is true.Open Protocol Events behavior detail
If sink.open.output-old-value is true, no difference
If sink.open.output-old-value is false
No impact
The p will be null
No impact
Debezium protocol behavior
If sink.debezium.output-old-value is true, no difference
If sink.debezium.output-old-value is false
No impact
The before fields is null
No impact
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note