Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api(ticdc): add swagger gen back #10791

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Conversation

sdojjy
Copy link
Member

@sdojjy sdojjy commented Mar 15, 2024

What problem does this PR solve?

Issue Number: close #10790

What is changed and how it works?

QA team will use the swagger.json to check the open API's compatibility, this PR add swagger gen to generate swagger.json file

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Mar 15, 2024
@sdojjy sdojjy changed the title add swagger gen back api(ticdc): add swagger gen back Mar 15, 2024
@ti-chi-bot ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 15, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Mar 15, 2024
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Merging #10791 (2bfa5c4) into master (80257c5) will decrease coverage by 0.0328%.
Report is 11 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
Components Coverage Δ
cdc 61.8639% <ø> (-0.0806%) ⬇️
dm 51.2152% <ø> (+0.0161%) ⬆️
engine 63.3582% <ø> (-0.0213%) ⬇️
Flag Coverage Δ
unit 57.5287% <ø> (-0.0328%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #10791        +/-   ##
================================================
- Coverage   57.5614%   57.5287%   -0.0328%     
================================================
  Files           853        853                
  Lines        126807     126881        +74     
================================================
+ Hits          72992      72993         +1     
- Misses        48374      48446        +72     
- Partials       5441       5442         +1     

@ti-chi-bot ti-chi-bot bot added the lgtm label Mar 19, 2024
Copy link
Contributor

ti-chi-bot bot commented Mar 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, asddongmen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [3AceShowHand,asddongmen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 19, 2024
Copy link
Contributor

ti-chi-bot bot commented Mar 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-15 08:12:30.227654139 +0000 UTC m=+1018777.249900528: ☑️ agreed by 3AceShowHand.
  • 2024-03-19 04:43:36.078672321 +0000 UTC m=+1351843.100918709: ☑️ agreed by asddongmen.

@ti-chi-bot ti-chi-bot bot merged commit 896bcc0 into pingcap:master Mar 19, 2024
29 checks passed
@sdojjy sdojjy added the needs-cherry-pick-release-8.0 Should cherry pick this PR to release-8.0 branch. label Mar 19, 2024
@sdojjy sdojjy deleted the add-swagger-gen branch March 19, 2024 07:15
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.0: #10813.

ti-chi-bot bot pushed a commit that referenced this pull request Mar 19, 2024
@sdojjy sdojjy added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Mar 20, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #10825.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.0 Should cherry pick this PR to release-8.0 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add swagger gen back
4 participants