Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mounter(ticdc): decode bytes-level checksum and encode columns-level checksum #10706

Merged
merged 39 commits into from
Jul 2, 2024
Merged

mounter(ticdc): decode bytes-level checksum and encode columns-level checksum #10706

merged 39 commits into from
Jul 2, 2024

Conversation

3AceShowHand
Copy link
Contributor

@3AceShowHand 3AceShowHand commented Mar 4, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #10969

What is changed and how it works?

  • mounter decode checksum v2

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

`None`

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 4, 2024
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 8, 2024
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 29, 2024
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 8, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 8, 2024

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 8, 2024
@3AceShowHand 3AceShowHand added area/ticdc Issues or PRs related to TiCDC. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. area/dm Issues or PRs related to DM. labels Jul 1, 2024
@3AceShowHand
Copy link
Contributor Author

/retest

2 similar comments
@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/test cdc-integration-mysql-test

4 similar comments
@3AceShowHand
Copy link
Contributor Author

/test cdc-integration-mysql-test

@3AceShowHand
Copy link
Contributor Author

/test cdc-integration-mysql-test

@3AceShowHand
Copy link
Contributor Author

/test cdc-integration-mysql-test

@3AceShowHand
Copy link
Contributor Author

/test cdc-integration-mysql-test

@3AceShowHand
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot added the area/dm Issues or PRs related to DM. label Jul 2, 2024
@3AceShowHand 3AceShowHand removed the area/dm Issues or PRs related to DM. label Jul 2, 2024
@ti-chi-bot ti-chi-bot bot added the area/dm Issues or PRs related to DM. label Jul 2, 2024
@3AceShowHand
Copy link
Contributor Author

/test cdc-integration-mysql-test

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, CharlesCheung96, D3Hunter, sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jul 2, 2024
@ti-chi-bot ti-chi-bot bot merged commit 7ddb1a3 into pingcap:master Jul 2, 2024
28 checks passed
@3AceShowHand
Copy link
Contributor Author

/cherry-pick release-8.2

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jul 3, 2024
@3AceShowHand @ti-chi-bot
mounter(ticdc): decode bytes-level checksum and encode columns-level …
d6c60e7 
…checksum (pingcap#10706)

close pingcap#10969
@ti-chi-bot
Copy link
Member

@3AceShowHand: new pull request created to branch release-8.2: #11380.

In response to this:

/cherry-pick release-8.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 3, 2024
Closed
@lance6716
Copy link
Contributor

/cherry-pick release-8.1

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jul 31, 2024
@3AceShowHand @ti-chi-bot
This is an automated cherry-pick of pingcap#10706
21fcca2 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 31, 2024
Closed
@ti-chi-bot
Copy link
Member

@lance6716: new pull request created to branch release-8.1: #11453.

In response to this:

/cherry-pick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdojjy sdojjy sdojjy approved these changes

@D3Hunter D3Hunter D3Hunter approved these changes

@asddongmen asddongmen asddongmen approved these changes

@CharlesCheung96 CharlesCheung96 CharlesCheung96 approved these changes

@hongyunyan hongyunyan Awaiting requested review from hongyunyan

Assignees
No one assigned
Labels
approved area/dm Issues or PRs related to DM. area/ticdc Issues or PRs related to TiCDC. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TiCDC supports verify bytes-level checksum
7 participants
@3AceShowHand @ti-chi-bot @lance6716 @sdojjy @D3Hunter @asddongmen @CharlesCheung96