Skip to content

test: stabilize flaky TestLoadDataOverflowBigintUnsigned#69775

Open
flaky-claw wants to merge 1 commit into
pingcap:masterfrom
flaky-claw:flakyfixer/case_4dbdc20e29b9-a3
Open

test: stabilize flaky TestLoadDataOverflowBigintUnsigned#69775
flaky-claw wants to merge 1 commit into
pingcap:masterfrom
flaky-claw:flakyfixer/case_4dbdc20e29b9-a3

Conversation

@flaky-claw

@flaky-claw flaky-claw commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close #68287

Problem Summary:
Flaky test TestLoadDataOverflowBigintUnsigned in pkg/executor/test/loaddatatest intermittently fails, so this PR stabilizes that path.

What changed and how does it work?

Root Cause

Duplicate LOAD DATA executions in one logical overflow test made the case vulnerable to time-threshold flakes under a slowed per-load path.

Fix

The patch preserves all five overflow inputs, expected stored values, and total warnings while removing one redundant LOAD DATA setup/commit path.

Verification

Spec:

  • target: pkg/executor/test/loaddatatest :: TestLoadDataOverflowBigintUnsigned
  • strategy: tidb.go_flaky.default
  • plan mode: BASELINE_ONLY
  • requirements: required case must execute; no skip; repeat count = 1
  • execution surface: GO_TEST_WITH_TAGS
  • build tags: intest, deadlock
  • baseline gates: required_flaky_gate, build_safety_gate, intent_guard_gate
  • feedback surface source: baseline_only

Observed result:

  • status: passed
  • required case executed: yes
  • submission decision: ALLOWED
  • note: Required flaky case executed during validation.
    Required flaky case was not skipped.
    target_flaky passed.
    package passed.
    build passed.
    lint passed.

Gate checklist:

  • timing_repro: SKIPPED
  • target_flaky: PASS
  • package: PASS
  • build: PASS
  • lint: PASS

Commands:

  • go test -json -tags=intest,deadlock ./pkg/executor/test/loaddatatest -run '^TestLoadDataOverflowBigintUnsigned$' -count=1
  • go test -json -tags=intest,deadlock ./pkg/executor/test/loaddatatest -count=1
  • make build
  • make lint

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Fixes #68287

Summary by CodeRabbit

  • Tests
    • Expanded coverage for unsigned bigint boundary-value handling.
    • Updated expected results and warning counts for overflow scenarios.

@ti-chi-bot ti-chi-bot Bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jul 12, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jul 12, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign wshwsh12 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 12, 2026
@coderabbitai

coderabbitai Bot commented Jul 12, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 654f2245-ed7b-40a9-be8e-6f25ff634898

📥 Commits

Reviewing files that changed from the base of the PR and between b94006d and 2abe9e5.

📒 Files selected for processing (1)
  • pkg/executor/test/loaddatatest/load_data_test.go

📝 Walkthrough

Walkthrough

The unsigned bigint load-data test replaces two overflow scenarios with one expanded boundary-value case and updates its expected selected rows and warning count.

Changes

Load-data overflow validation

Layer / File(s) Summary
Expand unsigned bigint overflow scenario
pkg/executor/test/loaddatatest/load_data_test.go
The test adds unsigned bigint boundary inputs and adjusts the expected rows and warnings.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested labels: approved, lgtm, ok-to-test

Suggested reviewers: windtalker, gengliqi

Poem

A rabbit bounds through bigint snow,
With unsigned numbers in a row.
New edges tested, warnings bright,
Expected rows now hop just right.
Fluffy checks pass through the night.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately reflects the main change: stabilizing a flaky test.
Description check ✅ Passed The description includes the required issue reference, problem summary, change details, tests, and release note section.
Linked Issues check ✅ Passed The changes address #68287 by removing the redundant LOAD DATA path and preserving the intended overflow behavior.
Out of Scope Changes check ✅ Passed The PR stays scoped to the flaky test fix and related test expectation updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

level=error msg="Running error: context loading failed: failed to load packages: failed to load packages: failed to load with go/packages: context deadline exceeded"
level=error msg="Timeout exceeded: try increasing it by passing --timeout option"


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.2713%. Comparing base (b94006d) to head (2abe9e5).

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #69775        +/-   ##
================================================
- Coverage   76.3194%   74.2713%   -2.0482%     
================================================
  Files          2041       2054        +13     
  Lines        560102     576205     +16103     
================================================
+ Hits         427467     427955       +488     
- Misses       131734     147935     +16201     
+ Partials        901        315       -586     
Flag Coverage Δ
integration 40.9163% <ø> (+1.2111%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 60.4471% <ø> (ø)
parser ∅ <ø> (∅)
br 47.4060% <ø> (-15.3154%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ti-chi-bot

ti-chi-bot Bot commented Jul 12, 2026

Copy link
Copy Markdown

@flaky-claw: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev_2 2abe9e5 link true /test check-dev2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky test: TestLoadDataOverflowBigintUnsigned in pkg/executor/test/loaddatatest

1 participant