test: stabilize flaky TestLoadDataOverflowBigintUnsigned#69775
test: stabilize flaky TestLoadDataOverflowBigintUnsigned#69775flaky-claw wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe unsigned bigint load-data test replaces two overflow scenarios with one expanded boundary-value case and updates its expected selected rows and warning count. ChangesLoad-data overflow validation
Estimated code review effort: 1 (Trivial) | ~3 minutes Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.12.2)level=error msg="Running error: context loading failed: failed to load packages: failed to load packages: failed to load with go/packages: context deadline exceeded" Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #69775 +/- ##
================================================
- Coverage 76.3194% 74.2713% -2.0482%
================================================
Files 2041 2054 +13
Lines 560102 576205 +16103
================================================
+ Hits 427467 427955 +488
- Misses 131734 147935 +16201
+ Partials 901 315 -586
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
@flaky-claw: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: close #68287
Problem Summary:
Flaky test
TestLoadDataOverflowBigintUnsignedinpkg/executor/test/loaddatatestintermittently fails, so this PR stabilizes that path.What changed and how does it work?
Root Cause
Duplicate LOAD DATA executions in one logical overflow test made the case vulnerable to time-threshold flakes under a slowed per-load path.
Fix
The patch preserves all five overflow inputs, expected stored values, and total warnings while removing one redundant LOAD DATA setup/commit path.
Verification
Spec:
pkg/executor/test/loaddatatest :: TestLoadDataOverflowBigintUnsignedtidb.go_flaky.defaultBASELINE_ONLYGO_TEST_WITH_TAGSintest, deadlockbaseline_onlyObserved result:
Required flaky case was not skipped.
target_flaky passed.
package passed.
build passed.
lint passed.
Gate checklist:
Commands:
go test -json -tags=intest,deadlock ./pkg/executor/test/loaddatatest -run '^TestLoadDataOverflowBigintUnsigned$' -count=1go test -json -tags=intest,deadlock ./pkg/executor/test/loaddatatest -count=1make buildmake lintCheck List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
Fixes #68287
Summary by CodeRabbit