planner: fix the global binding is not working when using Prepared Statement with "select ... as col ... group by col"

[qw4990]

What problem does this PR solve?

Issue Number: close #57992

Problem Summary: planner: fix the global binding is not working when using Prepared Statement with "select ... as col ... group by col"

What changed and how does it work?

planner: fix the global binding is not working when using Prepared Statement with "select ... as col ... group by col"

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Summary by CodeRabbit

• Bug Fixes
  • Improved prepared-statement plan caching by preserving binding context to improve reliability of subsequent executions.
  • Avoided redundant SQL binding work when a valid match is already present in the cache.
• Tests
  • Added a regression test covering global bindings for GROUP BY queries (including prepared-statement execution) to ensure bindings remain applied.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign 0xpoe for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• pkg/bindinfo/OWNERS
• pkg/planner/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 2aa4bde8-88ad-4804-9d3a-0e2e8066b5ec

📥 Commits

Reviewing files that changed from the base of the PR and between 999b280 and 8ce6b71.

📒 Files selected for processing (1)

• pkg/bindinfo/tests/bind_test.go

---

📝 Walkthrough

Walkthrough

Prepared statement plan cache entries now retain binding-matching context, while test-mode binding matching reuses eligible per-statement cache entries. Regression coverage verifies global bindings for alias-based GROUP BY queries during prepared execution.

Changes

Prepared statement binding

Layer / File(s)	Summary
Prepared plan binding context and regression coverage pkg/planner/core/plan_cache_utils.go, pkg/bindinfo/tests/bind_test.go	Prepared statements compute normalized binding metadata, store it in PlanCacheStmt.BindingInfo, and verify binding use for direct and prepared alias-based grouping queries.
Cached binding match reuse pkg/bindinfo/binding.go	The test-mode path returns cached binding results when a cache entry exists and no override is supplied.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant SQLClient
  participant GeneratePlanCacheStmtWithAST
  participant PlanCacheStmt
  participant MatchSQLBindingWithCache
  SQLClient->>GeneratePlanCacheStmtWithAST: prepare statement
  GeneratePlanCacheStmtWithAST->>PlanCacheStmt: store BindingInfo
  SQLClient->>MatchSQLBindingWithCache: execute prepared statement
  MatchSQLBindingWithCache->>MatchSQLBindingWithCache: reuse eligible cached match
  MatchSQLBindingWithCache-->>SQLClient: binding match result

Loading

Possibly related PRs

• pingcap/tidb#67820: Preserves and stores BindingInfo for prepared-statement plan-cache statements.

Suggested reviewers: hawkingrei

Poem

A rabbit watched the bindings hop,
Through prepared plans from start to stop.
Cached results now spring ahead,
With tables and digests neatly fed.
“No second match!” the rabbit said.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the prepared-statement global binding fix and matches the main change.
Description check	✅ Passed	The PR description includes the required issue reference, problem summary, change summary, and checklist/release-note sections.
Linked Issues check	✅ Passed	The code and regression test address #57992 by preserving binding context for prepared statements and verifying raw and prepared queries use the binding.
Out of Scope Changes check	✅ Passed	The changes stay focused on the binding/planner fix and its regression test, with no unrelated edits.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

level=error msg="Running error: context loading failed: failed to load packages: failed to load packages: failed to load with go/packages: context deadline exceeded"
level=error msg="Timeout exceeded: try increasing it by passing --timeout option"

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

❌ Patch coverage is 58.33333% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.0010%. Comparing base (531e40c) to head (8ce6b71).

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #69766        +/-   ##
================================================
- Coverage   76.3207%   74.0010%   -2.3197%     
================================================
  Files          2041       2056        +15     
  Lines        559975     578281     +18306     
================================================
+ Hits         427377     427934       +557     
- Misses       131697     150020     +18323     
+ Partials        901        327       -574     

Flag	Coverage Δ
integration	40.7446% <58.3333%> (+1.0394%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	60.4471% <ø> (ø)
parser	∅ <ø> (∅)
br	47.4060% <ø> (-15.3154%)	⬇️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.