*: extend DXF collation handling to support partition table and partial index#69734
*: extend DXF collation handling to support partition table and partial index#69734joechenrh wants to merge 8 commits into
Conversation
|
Skipping CI for Draft Pull Request. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close #69563
Problem Summary:
In next-gen deployments, DXF workers may run in a keyspace whose new-collation setting differs from the user keyspace that submitted the task. Some remaining ADD INDEX and IMPORT INTO paths still built expressions, encoded keys, or converted string-like values using the worker/global collation mode. This can make background execution use collation semantics that do not match the submitted task.
What changed and how does it work?
This PR keeps the new-collation mode captured by the submitted task/table snapshot and uses it in the remaining collation-sensitive DXF paths:
table.EncodingConfigas the explicit encoding snapshot carried by table/index/expression helpers.TableFromMeta(allocs, tblInfo)path unchanged, and let DXF paths passtables.WithEncodingConfig(...)when they need a fixed task snapshot.BuildSimpleExprhonorWithUseNewCollatewhen it builds schema fromWithTableInfo.Check List
Tests
Validated locally:
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.