-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]ddl: modify param at runtime for add-index on DXF local sort #59343
base: master
Are you sure you want to change the base?
Conversation
…te-dxf-dynamic-param
…te-dxf-dynamic-param
…te-dxf-dynamic-param
…te-dxf-dynamic-param
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @D3Hunter. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #59343 +/- ##
================================================
+ Coverage 73.0574% 74.9115% +1.8541%
================================================
Files 1689 1737 +48
Lines 466990 476610 +9620
================================================
+ Hits 341171 357036 +15865
+ Misses 104844 97106 -7738
- Partials 20975 22468 +1493
Flags with carried forward coverage won't be shown. Click here to find out more.
|
What problem does this PR solve?
Issue Number: ref #57497, ref #57229
Problem Summary:
What changed and how does it work?
Check List
Tests
ENV: 1pd/1tidb/1tikv
create table t(id bigint primary key auto_increment, b varchar(1024), c varchar(1024));
and insert 16M rowsrun
alter table t add index(b(128));
, the total index KV is about 5Gcase 1: with initial thread=2/batch_size=32, after
admin alter ddl jobs 131 thread = 8, batch_size = 256;
, time of encoding part changes from34s
->18s
case 2: with initial thread=4/batch_size=256, after
![wwg8I3shXS](https://private-user-images.githubusercontent.com/3312245/411190106-5e1d441b-1c86-4f5e-87a3-89cfe902f10c.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxNjg3MjEsIm5iZiI6MTczOTE2ODQyMSwicGF0aCI6Ii8zMzEyMjQ1LzQxMTE5MDEwNi01ZTFkNDQxYi0xYzg2LTRmNWUtODdhMy04OWNmZTkwMmYxMGMuanBnP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTBUMDYyMDIxWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ODg5MmY4MTNhYTMwZDE0OWI2ZGNmY2FlNWEwZTA4NDJiYjJlYmQ4NmVjODk3YmE2MGFjYmE1ZTkyZjdhY2UyZCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.8-FRKMIEp-FD_1KzJNMB-wQTLd5J1JTasJGCs69NLyw)
admin alter ddl jobs 133 thread = 1, batch_size = 32;
, time of encoding part changes from16s
->28s
case 3: with initial thread=4/batch_size=256/max_write_speed=100M, after
admin alter ddl jobs 135 max_write_speed = 0;
, time of importing part changes from53s
->23s
case 4: with initial thread=4/batch_size=256/max_write_speed=200M, after
admin alter ddl jobs 137 max_write_speed = '100M';
, time of importing part changes from26s
->49s
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.