-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: add tolerance for row count floating point comparison (#59241) #59334
base: release-8.1
Are you sure you want to change the base?
planner: add tolerance for row count floating point comparison (#59241) #59334
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
@terry1purcell This PR has conflicts, I have hold it. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@ti-chi-bot: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This is an automated cherry-pick of #59241
What problem does this PR solve?
Issue Number: close #59133
Problem Summary:
What changed and how does it work?
Due to precision errors in floating point, a small tolerance is needed to ensure that an unnecessary adjustments are not made for cardinality estimation. An arbitrary value of 0.00001 is used as the tolerance.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.