br/storage: adapt copier for azure and gcs

[YuJuncen]

What problem does this PR solve?

Issue Number: close #(TBD)

Problem Summary:

When log backup enabled, restoring from azure blob storage and GCS is still impossible because they didn't implement Copier.

What changed and how does it work?

This Added support to CopyFrom for AzureBlobStorage and GCSStorage.

Check List

Tests

• Unit test
  Tested Azure by azurite.
• Integration test
• Manual test (add detailed scripts or steps below)
  Start PiTR by:

#! /usr/bin/env fish

set pfx $fish_pid
set -q container || set container "tc-tidb-0"
set -q strg_prefix || set strg_prefix "test"

function strg
	echo "gs://br-datasets/$argv[1]"
end


function br
	kubectl exec '-it' $container '--' /br-for-restore $argv
end

br backup full -s (strg "juncen/tpcc-test/$pfx/$strg_prefix-full") $argv
gcloud storage cp (strg "juncen/tpcc-test/$pfx/$strg_prefix-full/backupmeta") ./.backupmeta.tmp
set backupts (cat ./.backupmeta.tmp | _get_brpb BackupMeta | rg -r '$1' 'end_version: (\d+)$')
br log start -s (strg "juncen/tpcc-test/$pfx/$strg_prefix-incr") --task-name fiolvit $argv --start-ts "$backupts"
br log status $argv

Restore a backup by:

/br-for-restore restore full -s 'gcs://br-datasets/juncen/tpcc-40' --checksum=false -u tc-pd:2379 --gcs.credentials-file /gcloud-cred.json

Then restore with:

/br-for-restore restore point -s 'gs://br-datasets/juncen/tpcc-test/3078828/test-incr' --checksum=false -u tc-pd:2379 --gcs.credentials-file /gcloud-cred.json --full-backup-storage 'gs://br-datasets/juncen/tpcc-test/3078828/test-full' 

Check the restored data:

TiDB root@tc-tidb:test> select count(*) from history;
+----------+
| count(*) |
+----------+
| 1200000  |
+----------+

• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from yujuncen, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• br/pkg/storage/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tiprow]

Hi @YuJuncen. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

Attention: Patch coverage is 3.57143% with 54 lines in your changes missing coverage. Please review.

Project coverage is 74.7431%. Comparing base (9c37399) to head (864e125).
Report is 53 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #59328        +/-   ##
================================================
+ Coverage   73.0489%   74.7431%   +1.6942%     
================================================
  Files          1684       1736        +52     
  Lines        466386     490085     +23699     
================================================
+ Hits         340690     366305     +25615     
+ Misses       104751     100710      -4041     
- Partials      20945      23070      +2125     

Flag	Coverage Δ
integration	48.6267% <0.0000%> (?)
unit	72.2681% <3.5714%> (+0.0263%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.6910% <ø> (ø)
parser	∅ <ø> (∅)
br	59.5919% <3.5714%> (+14.2687%)	⬆️

[BornChanger]

a good catch. if the error code returned does not contain the detailed reason, we have to document the restriction in release notes.

[BornChanger]

we also need to document the special requirements.

[ti-chi-bot]

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/needs-linked-issue label, please provide the linked issue number on one line in the PR body, for example: Issue Number: close #123 or Issue Number: ref #456.

_{📖 For more info, you can check the "Contribute Code" section in the development guide.}