-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: fix tikv crash when bool like cast(bit as char)
(#57484)
#59324
expression: fix tikv crash when bool like cast(bit as char)
(#57484)
#59324
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
4ae4df5
to
8f86331
Compare
@lcwangchao This PR has conflicts, I have hold it. |
/unhold |
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #59324 +/- ##
================================================
Coverage ? 73.6596%
================================================
Files ? 1097
Lines ? 353397
Branches ? 0
================================================
Hits ? 260311
Misses ? 76367
Partials ? 16719 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014, lcwangchao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This is an automated cherry-pick of #57484
What problem does this PR solve?
Issue Number: close #56494
What changed and how does it work?
When casting the bit type to a non binary string, this PR first convert bits to binary string first. This can ensure
HandleBinaryLiteral
can be used in the following code and convert binary to the specified collation with right behavior.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.