-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statistics: temporarily skip handling errors for DDL events (#58609) #58634
statistics: temporarily skip handling errors for DDL events (#58609) #58634
Conversation
Signed-off-by: Rustin170506 <[email protected]>
Signed-off-by: Rustin170506 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qw4990, Rustin170506 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #58634 +/- ##
================================================
Coverage ? 56.9422%
================================================
Files ? 1770
Lines ? 627102
Branches ? 0
================================================
Hits ? 357086
Misses ? 245828
Partials ? 24188
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
/test all |
@Rustin170506: No presubmit jobs available for pingcap/[email protected] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This is an automated cherry-pick of #58609
What problem does this PR solve?
Issue Number: ref #58545
Problem Summary:
What changed and how does it work?
In this PR, I just temporarily ignore this error and make sure the ddl notfier can proceed. I will spend more time figuring out how to avoid this kind of bug altogether.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.