fix: langfuse trace

pingcap · May 22, 2024 · c60f8e3 · c60f8e3
1 parent 47577b5
commit c60f8e3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/core/services/llamaindex/retrieving.ts b/src/core/services/llamaindex/retrieving.ts
@@ -90,6 +90,7 @@ export class LlamaindexRetrieveService extends AppRetrieveService {
     }
 
     // Cut up to 2 * top_k chunks for reranking.
+    // FIXME: why not to use the `search_top_k`?
     const rerankChunksLimit = top_k * 2;
     chunks = chunks.slice(0, rerankChunksLimit);
 

diff --git a/src/core/services/retrieving.ts b/src/core/services/retrieving.ts
@@ -106,7 +106,8 @@ export abstract class AppRetrieveService extends AppIndexBaseService {
       callbacks?.onRetrieved(retrieve.id, results);
 
       if (options.reversed) {
-        return results.reverse();
+        // use cloned array to avoid affecting langfuse output tracing.
+        return Array.from(results).reverse();
       } else {
         return results;
       }