Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hack: support k3s as provider for local-up #5727

Merged
merged 6 commits into from
Sep 24, 2024
Merged

Conversation

RidRisR
Copy link
Contributor

@RidRisR RidRisR commented Aug 30, 2024

What problem does this PR solve?

Add a new script to use k3s as k8s cluster provider and install tidb-operator
Add a new script to route between kind and k3s

What is changed and how does it work?

Add a new script to use k3s as k8s cluster provider and install tidb-operator
Add a new script to route between kind and k3s

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

Add a new script to use k3s as k8s cluster provider and install tidb-operator
Add a new script to route between kind and k3s

Copy link
Contributor

ti-chi-bot bot commented Aug 30, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tennix for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested a review from shonge August 30, 2024 08:50
@ti-chi-bot ti-chi-bot bot added the size/XXL label Aug 30, 2024
@RidRisR RidRisR marked this pull request as ready for review August 30, 2024 08:50
@BornChanger BornChanger requested review from csuzhangxc and WangLe1321 and removed request for howardlau1999 and shonge August 30, 2024 10:23

Usage: hack/local-up-operator.sh [-hd]
Usage: router.sh [-hd] [-p PROVIDER]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to rename this file to router.sh? or just use hack/local-up-operator.sh instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I overlooked this.
Maybe local-up-operator.sh is a better name, it could keep the reference consistent, if someone do referenced it.

@csuzhangxc
Copy link
Member

/run-pull-e2e-kind-basic

@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 21.47%. Comparing base (9ef26f8) to head (3c6d99e).
Report is 18 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (9ef26f8) and HEAD (3c6d99e). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (9ef26f8) HEAD (3c6d99e)
unittest 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5727       +/-   ##
===========================================
- Coverage   61.47%   21.47%   -40.01%     
===========================================
  Files         235      219       -16     
  Lines       30653    30626       -27     
===========================================
- Hits        18843     6576    -12267     
- Misses       9920    23068    +13148     
+ Partials     1890      982      -908     
Flag Coverage Δ
e2e 21.47% <ø> (?)
unittest ?

@csuzhangxc
Copy link
Member

/run-pull-e2e-kind-basic

@csuzhangxc csuzhangxc merged commit dca333c into pingcap:master Sep 24, 2024
5 checks passed
@csuzhangxc
Copy link
Member

/cherry-pick release-1.6

@ti-chi-bot
Copy link
Member

@csuzhangxc: new pull request created to branch release-1.6: #5747.

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

csuzhangxc pushed a commit that referenced this pull request Sep 24, 2024
@RidRisR RidRisR deleted the local-up branch September 25, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants