-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backup-manager: try to directly get the backup size from backupmeta before calculate the backup size (#5411) #5530
backup-manager: try to directly get the backup size from backupmeta before calculate the backup size (#5411) #5530
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: Leavrth <[email protected]>
blocked: need to update k8s package |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: WangLe1321 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/run-all-tests |
/run-pull-e2e-kind-br |
/run-pull-e2e-kind-across-kubernetes |
/run-pull-e2e-kind-basic |
/run-pull-e2e-kind-tngm |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.5 #5530 +/- ##
================================================
- Coverage 61.53% 47.80% -13.74%
================================================
Files 229 221 -8
Lines 29331 29982 +651
================================================
- Hits 18050 14333 -3717
- Misses 9499 13945 +4446
+ Partials 1782 1704 -78
|
/run-pull-e2e-kind |
/run-pull-e2e-kind-across-kubernetes |
/run-pull-e2e-kind |
This is an automated cherry-pick of #5411
What problem does this PR solve?
The current backup-manager cannot parse the backupmetaV2.
Close #5407
What is changed and how does it work?
try to directly get the backup size from backupmeta before calculate the backup size. Notice that if the br supports backupemtaV2, it also supports to record the backup size into the backupmeta.
Code changes
Tests
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.