Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backup-manager: try to directly get the backup size from backupmeta before calculate the backup size (#5411) #5530

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5411

What problem does this PR solve?

The current backup-manager cannot parse the backupmetaV2.

Close #5407

What is changed and how does it work?

try to directly get the backup size from backupmeta before calculate the backup size. Notice that if the br supports backupemtaV2, it also supports to record the backup size into the backupmeta.

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


Signed-off-by: Leavrth <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/M and removed size/XL labels Jan 25, 2024
@Leavrth
Copy link
Contributor

Leavrth commented Jan 26, 2024

blocked: need to update k8s package

@ti-chi-bot ti-chi-bot bot added size/L and removed size/M labels Aug 30, 2024
@ti-chi-bot ti-chi-bot bot added size/XL and removed size/L labels Aug 30, 2024
Copy link
Contributor

ti-chi-bot bot commented Aug 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: WangLe1321

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

ti-chi-bot bot commented Aug 30, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-30 09:16:20.97784138 +0000 UTC m=+3905.495894510: ☑️ agreed by WangLe1321.

@csuzhangxc
Copy link
Member

/run-all-tests

@csuzhangxc
Copy link
Member

/run-pull-e2e-kind-br

@csuzhangxc
Copy link
Member

/run-pull-e2e-kind-across-kubernetes

@csuzhangxc
Copy link
Member

/run-pull-e2e-kind-basic

@csuzhangxc
Copy link
Member

/run-pull-e2e-kind-tngm

@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.80%. Comparing base (d032996) to head (fb65c95).
Report is 17 commits behind head on release-1.5.

❗ There is a different number of reports uploaded between BASE (d032996) and HEAD (fb65c95). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (d032996) HEAD (fb65c95)
unittest 1 0
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.5    #5530       +/-   ##
================================================
- Coverage        61.53%   47.80%   -13.74%     
================================================
  Files              229      221        -8     
  Lines            29331    29982      +651     
================================================
- Hits             18050    14333     -3717     
- Misses            9499    13945     +4446     
+ Partials          1782     1704       -78     
Flag Coverage Δ
e2e 47.80% <ø> (?)
unittest ?

@csuzhangxc
Copy link
Member

/run-pull-e2e-kind

@csuzhangxc
Copy link
Member

/run-pull-e2e-kind-across-kubernetes

@csuzhangxc
Copy link
Member

/run-pull-e2e-kind

@csuzhangxc csuzhangxc merged commit 34d8cdc into pingcap:release-1.5 Sep 2, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants