Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert 'add missing tiproxy label' #5244

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Conversation

xhebox
Copy link
Contributor

@xhebox xhebox commented Aug 14, 2023

What problem does this PR solve?

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2023

Codecov Report

Merging #5244 (f70339b) into master (ddc83e6) will increase coverage by 7.43%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5244      +/-   ##
==========================================
+ Coverage   57.76%   65.19%   +7.43%     
==========================================
  Files         246      249       +3     
  Lines       29479    32815    +3336     
==========================================
+ Hits        17029    21395    +4366     
+ Misses      10795     9729    -1066     
- Partials     1655     1691      +36     
Flag Coverage Δ
e2e 48.60% <ø> (?)
unittest 57.77% <ø> (+0.01%) ⬆️

@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 15, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csuzhangxc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 15, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 15, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-15 01:50:16.748447154 +0000 UTC m=+595781.297463141: ☑️ agreed by csuzhangxc.

@xhebox xhebox enabled auto-merge (squash) August 15, 2023 05:16
@xhebox
Copy link
Contributor Author

xhebox commented Aug 15, 2023

/run-all-tests

@xhebox
Copy link
Contributor Author

xhebox commented Aug 15, 2023

/run pull-e2e-kind-serial
/run pull-e2e-kind-across-kubernetes

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 15, 2023

@xhebox: The label(s) /pull-e2e-kind-serial, /pull-e2e-kind-across-kubernetes cannot be applied, because the repository doesn't have them.

In response to this:

/run pull-e2e-kind-serial
/run pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@xhebox
Copy link
Contributor Author

xhebox commented Aug 15, 2023

/test pull-e2e-kind-serial
/test pull-e2e-kind-across-kubernetes

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 15, 2023

@xhebox: The label(s) /pull-e2e-kind-serial, /pull-e2e-kind-across-kubernetes cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-serial
/test pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 15, 2023

@xhebox: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind-serial
/test pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xhebox xhebox merged commit 808f587 into pingcap:master Aug 15, 2023
13 of 14 checks passed
xhebox added a commit that referenced this pull request Aug 21, 2023
csuzhangxc pushed a commit that referenced this pull request Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants