Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]Support intelligent update policy #4355

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

mikechengwei
Copy link
Contributor

@mikechengwei mikechengwei commented Jan 6, 2022

What problem does this PR solve?

#4130

What is changed and how does it work?

  • Pd statefulset use ondelete update policy deploy and use intelligent update policy , current support the non-leader pod update first.
  • TiDB/TiKV support metrics cache and intelligent update policy.

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@mikechengwei
Copy link
Contributor Author

For example:

pd member screenshot:
Screen Shot 2022-01-07 at 3 55 49 AM
pod update screenshot:( The order is pd-1 pd-0 pd-2)
Screen Shot 2022-01-07 at 3 58 36 AM
transfer leader log:
Screen Shot 2022-01-07 at 3 58 11 AM

@mikechengwei mikechengwei changed the title Pd support custom update policy , it can only evict leader once. Pd support custom update policy , it can only need to evict leader once. Jan 6, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2022

Codecov Report

Merging #4355 (2ab5b54) into master (eecea2b) will decrease coverage by 5.31%.
The diff coverage is 18.51%.

@@            Coverage Diff             @@
##           master    #4355      +/-   ##
==========================================
- Coverage   62.59%   57.27%   -5.32%     
==========================================
  Files         183      163      -20     
  Lines       19454    20112     +658     
==========================================
- Hits        12177    11520     -657     
- Misses       6143     7252    +1109     
- Partials     1134     1340     +206     
Flag Coverage Δ
e2e 57.27% <18.51%> (?)
unittest ?

@mikechengwei mikechengwei changed the title Pd support custom update policy , it can only need to evict leader once. [wip]Pd support custom update policy , it can only need to evict leader once. Jan 8, 2022
@mikechengwei mikechengwei changed the title [wip]Pd support custom update policy , it can only need to evict leader once. [WIP]Support intelligent update policy Jan 9, 2022
@ti-chi-bot
Copy link
Member

@mikechengwei: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


// IsEnableIntelligentOperation is enable intelligent operation
// +optional
IsEnableIntelligentOperation *bool `json:"isEnableIntelligentOperation,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intelligent can do too many operations 😂

Comment on lines +850 to +852
if tc.IsEnableIntelligentOperation() {

}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why an empty if here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants