-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]Support intelligent update policy #4355
base: master
Are you sure you want to change the base?
Conversation
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #4355 +/- ##
==========================================
- Coverage 62.59% 57.27% -5.32%
==========================================
Files 183 163 -20
Lines 19454 20112 +658
==========================================
- Hits 12177 11520 -657
- Misses 6143 7252 +1109
- Partials 1134 1340 +206
|
…perator into feature/updatepolicy
@mikechengwei: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
||
// IsEnableIntelligentOperation is enable intelligent operation | ||
// +optional | ||
IsEnableIntelligentOperation *bool `json:"isEnableIntelligentOperation,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
intelligent
can do too many operations 😂
if tc.IsEnableIntelligentOperation() { | ||
|
||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why an empty if
here?
What problem does this PR solve?
#4130
What is changed and how does it work?
ondelete
update policy deploy and use intelligent update policy , current support the non-leader pod update first.Code changes
Tests
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.