Skip to content

[WIP] memory quota optimization #5589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
lidezhu wants to merge 5 commits into
base: ldz/improve-log-puller052302
Choose a base branch
from
Draft

[WIP] memory quota optimization #5589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
aee059d
alpha version
lidezhu Jul 5, 2026
282dca7
add memory quota metrics
lidezhu Jul 6, 2026
e62a040
refactor
lidezhu Jul 7, 2026
0b2061b
fix
lidezhu Jul 7, 2026
5804874
try fix
lidezhu Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions logservice/eventstore/event_store.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,7 +460,7 @@ func (e *eventStore) Close(_ context.Context) error {
}

func (e *eventStore) RegisterDispatcher(
_ common.ChangeFeedID,
changefeedID common.ChangeFeedID,
dispatcherID common.DispatcherID,
dispatcherSpan *heartbeatpb.TableSpan,
startTs uint64,
Expand Down Expand Up @@ -678,7 +678,15 @@ func (e *eventStore) RegisterDispatcher(
serverConfig := config.GetGlobalServerConfig()
resolvedTsAdvanceInterval := int64(serverConfig.KVClient.AdvanceIntervalInMs)
// Note: don't hold any lock when call Subscribe
e.subClient.Subscribe(subStat.subID, *dispatcherSpan, startTs, consumeKVEvents, advanceResolvedTs, resolvedTsAdvanceInterval, bdrMode)
e.subClient.Subscribe(
subStat.subID,
logpuller.NewChangefeedSubscriptionMeta(changefeedID),
*dispatcherSpan,
startTs,
consumeKVEvents,
advanceResolvedTs,
resolvedTsAdvanceInterval,
bdrMode)
log.Info("new subscription created",
zap.Stringer("dispatcherID", dispatcherID),
zap.Uint64("startTs", startTs),
Expand Down
2 changes: 2 additions & 0 deletions logservice/eventstore/event_store_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,13 +121,15 @@ func (s *mockSubscriptionClient) AllocSubscriptionID() logpuller.SubscriptionID

func (s *mockSubscriptionClient) Subscribe(
subID logpuller.SubscriptionID,
meta logpuller.SubscriptionMeta,
span heartbeatpb.TableSpan,
startTs uint64,
consumeKVEvents func(raw []common.RawKVEntry, wakeCallback func()) bool,
advanceResolvedTs func(ts uint64),
advanceInterval int64,
bdrMode bool,
) {
_ = meta
s.mu.Lock()
defer s.mu.Unlock()
s.subscriptions[subID] = &mockSubscriptionStat{
Expand Down
2 changes: 1 addition & 1 deletion logservice/eventstore/pebble.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ func newPebbleOptions(dbNum int) *pebble.Options {

MaxOpenFiles: maxOpenFilesPerDB,

MaxConcurrentCompactions: func() int { return 6 },
MaxConcurrentCompactions: func() int { return 2 },

// Decrease compaction frequency
L0CompactionThreshold: 20,
Expand Down
Loading