chore(deps): bump go mod github.com/pingcap/tiflow#5495
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthrough
ChangesDependency Version Bumps
Estimated code review effort: 1 (Trivial) | ~3 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request updates several Go dependencies in go.mod and go.sum, including github.com/pingcap/kvproto, github.com/pingcap/tidb, github.com/pingcap/tiflow, and other packages to their newer versions. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Line 58: The TiDB dependency bump is unsafe because the current
github.com/pingcap/tidb version is known to be affected by multiple advisories.
Update the go.mod dependency to a patched TiDB release that addresses
GHSA-7fxj-fr3v-r9gj, GHSA-9g6g-xqv5-8g5w, and GO-2024-3284, or otherwise add
explicit justification for why this upgrade is exempt. Locate the change at the
github.com/pingcap/tidb entry in go.mod and keep the version aligned with any
related transitive updates.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 4fbb2766-d814-443e-9fb7-f7b9e9cf2f6c
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod
f42a9d0 to
2abe2e1
Compare
2abe2e1 to
30b8bcc
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Line 58: Update the github.com/pingcap/tidb dependency version to a patched
revision that is not affected by GO-2024-3284, GHSA-7fxj-fr3v-r9gj, or
GHSA-9g6g-xqv5-8g5w; if upgrading is not applicable, document the concrete
justification for this usage instead.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: ac63780a-7801-4ac0-ae3e-193aabb0d128
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod
7b79663 to
d70e0a0
Compare
There was a problem hiding this comment.
♻️ Duplicate comments (1)
go.mod (1)
58-58:⚠️ Potential issue | 🔴 CriticalDo not retain this TiDB revision without resolving the existing advisory finding.
Line 58 still pins the exact TiDB pseudo-version previously flagged for
GO-2024-3284,GHSA-7fxj-fr3v-r9gj, andGHSA-9g6g-xqv5-8g5w. The Go vulnerability database lists custom TiDB versions beforev8.2.0as affected, withv8.2.0identified as the patched version for the nil-pointer issue. (pkg.go.dev)Update to a patched revision, or document and verify that the vulnerable symbols are unreachable from
ticdc.#!/usr/bin/env bash set -euo pipefail go list -m -f '{{.Path}} {{.Version}}' github.com/pingcap/tidb govulncheck ./...🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@go.mod` at line 58, Update the github.com/pingcap/tidb dependency from the flagged pseudo-version to a patched release or revision at least equivalent to v8.2.0, then regenerate module metadata and verify with govulncheck ./.... If retaining the older revision, document and validate that the vulnerable symbols are unreachable from ticdc.Source: Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Duplicate comments:
In `@go.mod`:
- Line 58: Update the github.com/pingcap/tidb dependency from the flagged
pseudo-version to a patched release or revision at least equivalent to v8.2.0,
then regenerate module metadata and verify with govulncheck ./.... If retaining
the older revision, document and validate that the vulnerable symbols are
unreachable from ticdc.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 7d5c2c21-fa3c-405d-a537-81ab6b3c2a1c
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod
33bf4e0 to
a733f2b
Compare
a733f2b to
e7409bf
Compare
What problem does this PR solve?
Auto generated by bot.
Issue Number: ref #1074
Release note
Summary by CodeRabbit