Skip to content

Update TiProxy to v1.3.3 (#23905) - #23908

Merged
ti-chi-bot[bot] merged 6 commits into
pingcap:release-8.5from
ti-chi-bot:cherry-pick-23905-to-release-8.5
Sep 21, 2026
Merged

ti-chi-bot[bot] merged 6 commits into
pingcap:release-8.5from
ti-chi-bot:cherry-pick-23905-to-release-8.5

Conversation

@ti-chi-bot

@ti-chi-bot ti-chi-bot commented Sep 20, 2026

Copy link
Copy Markdown
Member

This is an automated cherry-pick of #23905

What is changed, added, or deleted? (Required)

v1.3.3 was released.

  • Add some configs.
  • Add some grafana panels.
  • Update the default balance factor order.
  • Update the recommanded version to v1.3.3.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)

What is the related PR or file link(s)?

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Summary by CodeRabbit

  • Documentation
    • Added TiProxy v1.3.3 configuration guidance for backend failover, memory-based connection protection, routing and load-balancing policies, and high-availability GARP behavior.
    • Documented the Grafana Connection Lifetime metric, including average and P99 values.
    • Updated load-balancing policy priorities and clarified status- and connection-count-based behavior.
    • Updated configuration examples to use TiProxy v1.3.3.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Sep 20, 2026
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 20, 2026
12 tasks
@ti-chi-bot

Copy link
Copy Markdown
Member Author

@qiancai This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

@ti-chi-bot

ti-chi-bot Bot commented Sep 20, 2026

Copy link
Copy Markdown

@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@coderabbitai

coderabbitai Bot commented Sep 20, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: pingcap/docs/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: dd2e39db-c696-4c35-9f8e-95396a6696f6

📥 Commits

Reviewing files that changed from the base of the PR and between f7f215f and d0c487a.

📒 Files selected for processing (1)
  • tiproxy/tiproxy-configuration.md
💤 Files with no reviewable changes (1)
  • tiproxy/tiproxy-configuration.md

Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.


📝 Walkthrough

Walkthrough

The PR updates TiProxy v1.3.3 documentation. It adds configuration references, revises load-balancing behavior, documents a Grafana metric, and updates example versions.

Changes

TiProxy v1.3.3 documentation

Layer / File(s) Summary
Configuration reference updates
tiproxy/tiproxy-configuration.md
Documents backend failover, memory thresholds, routing policies, load-balancing settings, and HA GARP behavior.
Load-balancing behavior documentation
tiproxy/tiproxy-load-balance.md
Updates policy priorities, status checks, connection-count configuration, and links to balance settings.
Monitoring and version examples
tiproxy/tiproxy-grafana.md, tiproxy/tiproxy-overview.md
Adds the Connection Lifetime metric and changes TiProxy example versions from v1.3.2 to v1.3.3.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: qiancai

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the primary change: updating TiProxy to v1.3.3. It is concise and specific.
Description check ✅ Passed The description includes the required change summary, affected TiDB versions, related PR link, AI involvement, and change-category checklist. It is sufficiently complete for this documentation update.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository: pingcap/docs/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 4ab1229d-e286-4e75-97eb-e9b9b49d2684

📥 Commits

Reviewing files that changed from the base of the PR and between 884aa5a and f259787.

📒 Files selected for processing (4)
  • tiproxy/tiproxy-configuration.md
  • tiproxy/tiproxy-grafana.md
  • tiproxy/tiproxy-load-balance.md
  • tiproxy/tiproxy-overview.md

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.

Comment thread tiproxy/tiproxy-configuration.md Outdated
Comment thread tiproxy/tiproxy-configuration.md Outdated
Comment thread tiproxy/tiproxy-configuration.md Outdated
Comment thread tiproxy/tiproxy-configuration.md Outdated
@qiancai qiancai added the needs-cherry-pick-master Should cherry pick this PR to master branch. label Sep 20, 2026
Comment thread tiproxy/tiproxy-configuration.md Outdated
Comment thread tiproxy/tiproxy-configuration.md Outdated
Comment thread tiproxy/tiproxy-configuration.md Outdated
Comment thread tiproxy/tiproxy-configuration.md Outdated
Comment thread tiproxy/tiproxy-configuration.md Outdated
Comment thread tiproxy/tiproxy-configuration.md Outdated
Comment thread tiproxy/tiproxy-grafana.md Outdated
Comment thread tiproxy/tiproxy-load-balance.md Outdated
Comment thread tiproxy/tiproxy-configuration.md Outdated
Comment thread tiproxy/tiproxy-load-balance.md Outdated
@qiancai
qiancai requested a review from djshow832 September 20, 2026 09:50
@ti-chi-bot

ti-chi-bot Bot commented Sep 20, 2026

Copy link
Copy Markdown

@djshow832: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@qiancai qiancai removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 21, 2026
@qiancai

qiancai commented Sep 21, 2026

Copy link
Copy Markdown
Collaborator

/approve

@ti-chi-bot ti-chi-bot Bot added the approved label Sep 21, 2026
@qiancai

qiancai commented Sep 21, 2026

Copy link
Copy Markdown
Collaborator

/approve

@ti-chi-bot

ti-chi-bot Bot commented Sep 21, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
ti-chi-bot Bot merged commit 63ffe3e into pingcap:release-8.5 Sep 21, 2026
12 checks passed
@ti-chi-bot
ti-chi-bot Bot deleted the cherry-pick-23905-to-release-8.5 branch September 21, 2026 01:39
@ti-chi-bot

Copy link
Copy Markdown
Member Author

In response to a cherrypick label: new pull request created to branch master: #23916.
But this PR has conflicts, please resolve them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-cherry-pick-master Should cherry pick this PR to master branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants