releases: fix typos and a mistranslation-derived wording issue in release notes - #23735
releases: fix typos and a mistranslation-derived wording issue in release notes#23735yahonda wants to merge 1 commit into
Conversation
…ease notes - INFORMSTION_SCHEMA -> INFORMATION_SCHEMA in release-5.4.3.md - OPRDERBY -> ORDER BY in release-6.5.7.md, release-7.1.4.md, release-7.5.1.md - "stock data" (a literal rendering of Chinese 存量数据) -> "existing data" in release-5.0.6.md
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (5)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe release notes update one TiCDC description and correct terminology in four TiDB bug-fix entries. No code or public declarations change. ChangesRelease note corrections
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This updates release-note wording and corrects typos without changing product behavior. No current merge-readiness risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What is changed, added or deleted? (Required)
Fixes 3 defects in English release notes found while reviewing Japanese translation PRs #23598/#23599:
INFORMSTION_SCHEMA->INFORMATION_SCHEMAinreleases/release-5.4.3.mdOPRDERBY->ORDER BYinreleases/release-6.5.7.md,releases/release-7.1.4.md,releases/release-7.5.1.md(same bullet, duplicated across 3 files for issue #49377)releases/release-5.0.6.md: "scanning stock data" -> "scanning existing data". The Chinese source (docs-cn) uses 存量数据, an economics term meaning "stock" as opposed to "flow/incremental" data; the literal English rendering "stock data" reads as financial stock-market data to English readers and is misleading. Confirmed against the linked issue (CDC cloud: [CDC:ErrMetaListDatabases][tikv:9006]GC life time is shorter than transaction duration, transaction starts at 2021-08-05 16:54:32.127 +0800 CST, GC safe point is 2021-08-05 17:25:38.127 +0800 CST"] tiflow#2470), which describes a resumed changefeed's initial/backlog scan hitting a GC-related failure — "existing data" (as opposed to newly-incoming/incremental data) matches that context.Which TiDB version(s) do your changes apply to? (Required)
Summary by CodeRabbit
INFORMATION_SCHEMA, andORDER BY.LIMIT/ORDER BYclauses in nestedUNIONqueries.