Skip to content

i18n(ja): restore dropped version number in BR mysql-schema restore FAQ - #23734

Merged
qiancai merged 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:fix-ja-backup-faq-missing-version-number
Sep 4, 2026
Merged

i18n(ja): restore dropped version number in BR mysql-schema restore FAQ#23734
qiancai merged 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:fix-ja-backup-faq-missing-version-number

Conversation

@yahonda

@yahonda yahonda commented Sep 4, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

Restore a dropped version number in faq/backup-and-restore-faq.md. The EN source reads:

Starting from BR v5.1.0, when you perform a full backup, BR backs up the tables in the mysql schema. Before BR v6.2.0, under default configuration, BR only restores user data, but does not restore tables in the mysql schema.

The Japanese translation dropped the version number v6.2.0 from the second sentence, reading "BRより前" ("before BR") instead of "BR v6.2.0より前" ("before BR v6.2.0").

Before:

BR v5.1.0以降では、フルバックアップを実行すると、 BRは**mysqlスキーマ内のテーブル**をバックアップします。BRより前のデフォルト設定では、 BRはユーザーデータのみを復元し、 mysqlスキーマ内のテーブルは復元しません。

After:

BR v5.1.0以降では、フルバックアップを実行すると、 BRは**mysqlスキーマ内のテーブル**をバックアップします。BR v6.2.0より前のデフォルト設定では、 BRはユーザーデータのみを復元し、 mysqlスキーマ内のテーブルは復元しません。

Which TiDB version(s) do your changes apply to? (Required)

  • i18n-ja-release-8.5 (TiDB Japanese documentation for TiDB 8.5 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Summary by CodeRabbit

  • Documentation
    • Corrected the backup and restore FAQ to clarify that the default setting applies to versions earlier than BR v6.2.0.

EN: "Before BR v6.2.0, under default configuration, BR only restores
user data...". The JA translation dropped "v6.2.0", reading as "before
BR" (BRより前) instead of "before BR v6.2.0" (BR v6.2.0より前).
@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 4, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 4, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign oreoxmt for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 35b9737b-ff62-43f4-b656-c83ca7fca429

📥 Commits

Reviewing files that changed from the base of the PR and between 6b1f679 and 7234305.

📒 Files selected for processing (1)
  • faq/backup-and-restore-faq.md

Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

FAQの復元動作に関する説明を更新し、デフォルト設定の適用対象をBR v6.2.0より前と明記しました。

Changes

バックアップと復元FAQ

Layer / File(s) Summary
復元設定の適用バージョン更新
faq/backup-and-restore-faq.md
mysqlスキーマ内テーブルをデフォルトで復元しない設定の適用対象を「BR v6.2.0より前」に修正しました。

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 72343

The Japanese FAQ now correctly identifies BR v6.2.0 as the version boundary for the default MySQL schema restore behavior. No current merge-readiness risk remains.

Suggested reviewers: qiancai

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the Japanese localization change and the restoration of the dropped version number in the BR MySQL schema restore FAQ.
Description check ✅ Passed The description explains the correction, shows the before-and-after text, identifies the affected documentation branch, and records AI involvement. The related-link fields are blank, but they are non-…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the correction, shows the before-and-after text, identifies the affected documentation branch, and records AI involvement. The related-link fields are blank, but they are non-critical for this small documentation fix.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Sep 4, 2026
@qiancai
qiancai merged commit 11d86b3 into pingcap:i18n-ja-release-8.5 Sep 4, 2026
3 of 8 checks passed
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 4, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 4, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-09-04 12:21:34.42427273 +0000 UTC m=+1454729.595366840: ☑️ agreed by qiancai.

@yahonda
yahonda deleted the fix-ja-backup-faq-missing-version-number branch September 7, 2026 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants