Skip to content

i18n(ja): fix version-attribution swap in GBK compatibility notes - #23733

Merged
qiancai merged 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:fix-ja-character-set-gbk-subject-swap
Sep 4, 2026
Merged

i18n(ja): fix version-attribution swap in GBK compatibility notes#23733
qiancai merged 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:fix-ja-character-set-gbk-subject-swap

Conversation

@yahonda

@yahonda yahonda commented Sep 4, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

Fix a version-attribution swap in character-set-gbk.md's TiCDC and BR compatibility notes. For both TiCDC and BR, the EN source gives two distinct claims:

  1. "<Tool> versions earlier than vX.Y.Z do not support ..." — the tool's own version is earlier than X.Y.Z.
  2. "No version of <Tool> supports ... to TiDB clusters earlier than vX.Y.Z" — a broader claim: regardless of the tool's version, it cannot target a TiDB cluster whose version is earlier than X.Y.Z.

The Japanese translation reattached "earlier than vX.Y.Z" to the tool's own version in both sentences, so the second (broader) claim was mistranslated into a near-duplicate of the first, losing the actual meaning.

Before (TiCDC):

TiCDC v6.1.0より前のバージョンでは、charset=GBKテーブルのレプリケーションはサポートされていません。v6.1.0より前のバージョンのTiCDCでは、TiDBクラスターへのcharset=GBKテーブルのレプリケーションはサポートされていません。

After (TiCDC):

TiCDC v6.1.0より前のバージョンでは、charset=GBKテーブルのレプリケーションはサポートされていません。また、TiCDCのバージョンによらず、v6.1.0より前のTiDBクラスターへのcharset=GBKテーブルのレプリケーションはサポートされていません。

The same fix is applied to the parallel BR sentence.

Which TiDB version(s) do your changes apply to? (Required)

  • i18n-ja-release-8.5 (TiDB Japanese documentation for TiDB 8.5 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

The EN source's second sentence for TiCDC and BR compatibility
attributes "earlier than vX.Y.Z" to the TiDB cluster's version
("No version of TiCDC/BR supports ... to TiDB clusters earlier than
vX.Y.Z"), a broader claim than the first sentence. The JA translation
reattached the version qualifier to TiCDC/BR's own version in both
sentences, effectively duplicating the first sentence instead of
conveying the second, broader claim.
@ti-chi-bot

ti-chi-bot Bot commented Sep 4, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign overvenus for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 4, 2026
@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 55 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 45ad16c3-4053-4e57-967a-5845cf5d0584

📥 Commits

Reviewing files that changed from the base of the PR and between 6b1f679 and 6fcad9e.

📒 Files selected for processing (1)
  • character-set-gbk.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Sep 4, 2026
@qiancai
qiancai merged commit dd0a5d0 into pingcap:i18n-ja-release-8.5 Sep 4, 2026
5 of 9 checks passed
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 4, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 4, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-09-04 12:21:14.928326415 +0000 UTC m=+1454710.099420551: ☑️ agreed by qiancai.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants