Skip to content

i18n(ja): restore dropped negation in Private Endpoint firewall limitation - #23732

Open
yahonda wants to merge 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:fix-ja-serverless-limitations-negation
Open

i18n(ja): restore dropped negation in Private Endpoint firewall limitation#23732
yahonda wants to merge 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:fix-ja-serverless-limitations-negation

Conversation

@yahonda

@yahonda yahonda commented Sep 4, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

Fix a dropped negation in tidb-cloud/serverless-limitations.md line 24. The English source states a limitation:

No Firewall Rules support for Private Endpoint.

The Japanese translation dropped the "No", producing a garbled, seemingly affirmative fragment:

Before:

プライベートエンドポイントのサポートファイアウォールルール

After:

プライベートエンドポイントはファイアウォールルールをサポートしていません。

Which TiDB version(s) do your changes apply to? (Required)

  • i18n-ja-release-8.5 (TiDB Japanese documentation for TiDB 8.5 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Summary by CodeRabbit

  • Documentation
    • Clarified the Japanese documentation to state that private endpoints do not support firewall rules.

…ation

The Japanese sentence dropped the English "No" negation, turning a
stated limitation ("No Firewall Rules support for Private Endpoint")
into a garbled, seemingly affirmative fragment.
@ti-chi-bot

ti-chi-bot Bot commented Sep 4, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign csuzhangxc for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 4, 2026
@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: b7b7399d-bf0c-4081-b012-bf393ea22eed

📥 Commits

Reviewing files that changed from the base of the PR and between 6b1f679 and ed3f712.

📒 Files selected for processing (1)
  • tidb-cloud/serverless-limitations.md

Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The serverless limitations documentation corrects the connection limitation text. It now states that private endpoints do not support firewall rules.

Changes

Serverless documentation

Layer / File(s) Summary
Clarify connection limitation
tidb-cloud/serverless-limitations.md
The connection limitation bullet now clearly states that private endpoints do not support firewall rules.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to ed3f7

The Japanese Serverless limitation now correctly states that Private Endpoints do not support Firewall Rules. The documentation correction is ready to merge.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: restoring the missing negation in the Japanese Private Endpoint firewall limitation.
Description check ✅ Passed The description explains the file change, the reason for the change, the before-and-after text, the affected documentation branch, and AI involvement. The related-link fields are empty, but the requir…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the file change, the reason for the change, the before-and-after text, the affected documentation branch, and AI involvement. The related-link fields are empty, but the required information is otherwise complete.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant