Skip to content

i18n(ja): fix self-referential comparison in soft-pending-compaction-bytes-limit - #23730

Merged
qiancai merged 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:fix-ja-flow-control-self-comparison
Sep 4, 2026
Merged

i18n(ja): fix self-referential comparison in soft-pending-compaction-bytes-limit#23730
qiancai merged 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:fix-ja-flow-control-self-comparison

Conversation

@yahonda

@yahonda yahonda commented Sep 4, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

Fix a self-referential comparison in tikv-configuration-file.md's soft-pending-compaction-bytes-limit section (v8.5.5+ override condition). The Japanese translation compared storage.flow-control.soft-pending-compaction-bytes-limit against itself instead of comparing this configuration item's own value against it, as the English source states:

... this configuration item is overridden by storage.flow-control.soft-pending-compaction-bytes-limit only when its value is greater than storage.flow-control.soft-pending-compaction-bytes-limit.

Before:

...この設定項目は、 storage.flow-control.soft-pending-compaction-bytes-limit値がstorage.flow-control.soft-pending-compaction-bytes-limitより大きい場合にのみ上書きされます。

After:

...この設定項目は、その値がstorage.flow-control.soft-pending-compaction-bytes-limitより大きい場合にのみ、 storage.flow-control.soft-pending-compaction-bytes-limitによって上書きされます。

This matches the parallel, correctly-translated sentence for level0-slowdown-writes-trigger a few sections above.

Which TiDB version(s) do your changes apply to? (Required)

  • i18n-ja-release-8.5 (TiDB Japanese documentation for TiDB 8.5 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s): EN source at tikv-configuration-file.md line ~1767 on release-8.5

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Summary by CodeRabbit

  • Documentation
    • Corrected the description of the soft-pending-compaction-bytes-limit setting in v8.5.5 to accurately explain when its value overrides the storage flow-control threshold.

…bytes-limit

The v8.5.5+ override condition compared
storage.flow-control.soft-pending-compaction-bytes-limit against itself
instead of against this configuration item's own value, as the English
source states ("only when its value is greater than
storage.flow-control.soft-pending-compaction-bytes-limit").
@ti-chi-bot ti-chi-bot Bot added the missing-translation-status This PR does not have translation status info. label Sep 4, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 4, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lance6716 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 4, 2026
@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 2f7a875c-082b-4189-9379-87471de2fa8c

📥 Commits

Reviewing files that changed from the base of the PR and between 6b1f679 and b2e61aa.

📒 Files selected for processing (1)
  • tikv-configuration-file.md

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The v8.5.5 soft-pending-compaction-bytes-limit documentation now states the correct condition for flow-control threshold overrides.

Changes

Configuration Documentation

Layer / File(s) Summary
Correct threshold override condition
tikv-configuration-file.md
The v8.5.5 description now states that the flow-control threshold overrides the RocksDB threshold only when the RocksDB value is larger.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to b2e61

The Japanese TiKV configuration documentation now correctly describes when the flow-control threshold overrides the RocksDB setting. The change is ready to merge.

Suggested reviewers: qiancai

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the Japanese documentation fix and the affected configuration comparison.
Description check ✅ Passed The description explains the correction, affected TiDB version, reference source, and AI involvement. It provides sufficient context for review.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Sep 4, 2026
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 4, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 4, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-09-04 12:20:05.518449922 +0000 UTC m=+1454640.689544040: ☑️ agreed by qiancai.

@qiancai
qiancai merged commit 25ec1e7 into pingcap:i18n-ja-release-8.5 Sep 4, 2026
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants