release notes: include security dependency fixes in AI output - #23727
release notes: include security dependency fixes in AI output#23727qiancai wants to merge 2 commits into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe release-note prompt requires release notes for security fixes in dependencies shipped with TiDB components. It excludes dependencies used exclusively by tests, development or build tooling, or other non-shipped code. ChangesSecurity dependency classification
Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: 🟡 Moderate · up to Shipped dependency vulnerability fixes may still be omitted from release notes when their impact appears indirect, leaving the intended security-release-note classification incomplete. Clarify the rule precedence before merge. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Team
Run ID: 554ec7ee-eda9-4dec-ab8b-2cd2927cf1ea
📒 Files selected for processing (1)
scripts/release-notes-ai-generator/prompts/release-note.md
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.
What is changed, added or deleted? (Required)
Update the AI release-note classification prompt to treat known or reported vulnerability fixes in dependencies shipped with TiDB components as release-note-worthy, even when only dependency manifests or lockfiles change.
Keep dependency updates used exclusively by tests, development or build tooling, or other unshipped code eligible for the not-needed verdict.
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit