migrate-from-mysql-using-aws-dms: fix "test" mislabeled as a system database - #23700
migrate-from-mysql-using-aws-dms: fix "test" mislabeled as a system database#23700yahonda wants to merge 2 commits into
Conversation
…atabase `test` is a default user database, not a system database (unlike INFORMATION_SCHEMA, PERFORMANCE_SCHEMA, mysql, and sys). Reword to "default databases" so the list's shared label is accurate for all five entries. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Skipping CI for Draft Pull Request. |
📝 WalkthroughWalkthroughThe AWS DMS migration guide now instructs users to select only the databases and tables they want to migrate. It warns that the default ChangesAWS DMS documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: 🔵 Low · up to The migration guidance remains functionally useful, but its terminology does not match the intended clarification that includes default user databases such as 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Description checkExplanation The description explains the change, its rationale, and the affected versions. It omits some template sections, such as related links and AI agent involvement, but the required change and version information are complete. Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: Grace Cai <qqzczy@126.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@yahonda: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Team
Run ID: 5fc413b9-6e2e-4ed6-83ba-b32ecad31cc2
📒 Files selected for processing (1)
tidb-cloud/migrate-from-mysql-using-aws-dms.md
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.
What is changed, added or deleted? (Required)
The doc listed
testalongsideINFORMATION_SCHEMA,PERFORMANCE_SCHEMA,mysql, andsysunder the label "system databases".testis a default user database TiDB/MySQL creates for convenience, not a system (metadata) database like the other four. Reworded the shared label to "default databases", which accurately covers all five entries without changing the practical guidance (still filter out all five when setting up an AWS DMS migration task).Which TiDB version(s) do your changes apply to? (Required)
Do your changes match any of the following descriptions? (Required)
markdown-pagesrepositorySummary by CodeRabbit
%wildcard may include MySQL system databases and cause the migration task to fail.