Skip to content

migrate-from-mysql-using-aws-dms: fix "test" mislabeled as a system database - #23700

Open
yahonda wants to merge 2 commits into
pingcap:release-8.5from
yahonda:fix-en-test-not-system-db
Open

migrate-from-mysql-using-aws-dms: fix "test" mislabeled as a system database#23700
yahonda wants to merge 2 commits into
pingcap:release-8.5from
yahonda:fix-en-test-not-system-db

Conversation

@yahonda

@yahonda yahonda commented Sep 2, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

The doc listed test alongside INFORMATION_SCHEMA, PERFORMANCE_SCHEMA, mysql, and sys under the label "system databases". test is a default user database TiDB/MySQL creates for convenience, not a system (metadata) database like the other four. Reworded the shared label to "default databases", which accurately covers all five entries without changing the practical guidance (still filter out all five when setting up an AWS DMS migration task).

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v8.5 (LTS)

Do your changes match any of the following descriptions? (Required)

  • Delete files in the markdown-pages repository
  • Change the directory
  • Need modification after machine translation
  • Screenshots or GIFs are included in the changes

Summary by CodeRabbit

  • Documentation
    • Updated the AWS DMS migration guide to recommend explicitly selecting only the databases and tables intended for migration.
    • Clarified that using the default % wildcard may include MySQL system databases and cause the migration task to fail.

…atabase

`test` is a default user database, not a system database (unlike
INFORMATION_SCHEMA, PERFORMANCE_SCHEMA, mysql, and sys). Reword to
"default databases" so the list's shared label is accurate for all
five entries.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@ti-chi-bot

ti-chi-bot Bot commented Sep 2, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 2, 2026
@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The AWS DMS migration guide now instructs users to select only the databases and tables they want to migrate. It warns that the default % wildcard can include MySQL system databases and cause the migration task to fail.

Changes

AWS DMS documentation

Layer / File(s) Summary
Migration task selection guidance
tidb-cloud/migrate-from-mysql-using-aws-dms.md
Updates the prerequisite to recommend explicit database and table selection. The guidance lists system databases that the % wildcard might migrate and identifies possible task failure.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: 🔵 Low · up to 1e419

The migration guidance remains functionally useful, but its terminology does not match the intended clarification that includes default user databases such as test. Update the wording before merge.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the AWS DMS documentation change and the correction of the test database label.
Description check ✅ Passed The description explains the change, its rationale, and the affected versions. It omits some template sections, such as related links and AI agent involvement, but the required change and version info…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the change, its rationale, and the affected versions. It omits some template sections, such as related links and AI agent involvement, but the required change and version information are complete.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 2, 2026
@yahonda
yahonda marked this pull request as ready for review September 2, 2026 05:51
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 2, 2026
Comment thread tidb-cloud/migrate-from-mysql-using-aws-dms.md Outdated
@qiancai qiancai self-assigned this Sep 3, 2026
@qiancai qiancai added the translation/doing This PR's assignee is translating this PR. label Sep 3, 2026
@ti-chi-bot ti-chi-bot Bot removed the missing-translation-status This PR does not have translation status info. label Sep 3, 2026
@qiancai qiancai added needs-cherry-pick-master Should cherry pick this PR to master branch. missing-translation-status This PR does not have translation status info. and removed missing-translation-status This PR does not have translation status info. labels Sep 3, 2026
Co-authored-by: Grace Cai <qqzczy@126.com>
@ti-chi-bot

ti-chi-bot Bot commented Sep 3, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from qiancai. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot

ti-chi-bot Bot commented Sep 3, 2026

Copy link
Copy Markdown

@yahonda: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-verify 1e4196d link true /test pull-verify

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 5fc413b9-6e2e-4ed6-83ba-b32ecad31cc2

📥 Commits

Reviewing files that changed from the base of the PR and between 7b48fb9 and 1e4196d.

📒 Files selected for processing (1)
  • tidb-cloud/migrate-from-mysql-using-aws-dms.md

Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.

Comment thread tidb-cloud/migrate-from-mysql-using-aws-dms.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-cherry-pick-master Should cherry pick this PR to master branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/doing This PR's assignee is translating this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants