functions-and-operators, releases: clarify TIDB_DECODE_SQL_DIGESTS wording - #23686
functions-and-operators, releases: clarify TIDB_DECODE_SQL_DIGESTS wording#23686yahonda wants to merge 5 commits into
Conversation
…rding Reword "a form without formats and arguments" to "without value formats or arguments" to remove the redundant use of "form"/"formats" -- when translated, both words map to the identical term in some languages, making the parenthetical read as self-contradictory (a "form" without "format").
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe documentation updates descriptions of ChangesSQL digest documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This clarifies normalized SQL wording across the relevant documentation without changing product behavior. The update is ready to merge. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Description checkExplanation The description explains the wording change and its translation-related rationale. It includes the required change summary and affected version, plus the remaining template sections. The reference-link fields are empty, but they are non-critical for this documentation-only change. Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
[LGTM Timeline notifier]Timeline:
|
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
What is changed, added or deleted? (Required)
Rewords the parenthetical describing
TIDB_DECODE_SQL_DIGESTS()'s output from"a form without formats and arguments" to "without value formats or arguments",
in 4 places (3 in
functions-and-operators/tidb-functions.md, 1 inreleases/release-5.2.0.md).The original phrasing uses "form" and "formats" as two separate words with the
same root meaning right next to each other ("a form without formats"), which
reads as slightly self-contradictory even in English, and becomes worse once
translated: in Japanese, both "form" and "format" map to the same word (形式),
so the translated sentence ends up reading as "a 形式 without 形式" — literally
"a form without form" — with no way to distinguish the two senses. Simplifying
to a single clear phrase avoids this.
Found while reviewing the Japanese translation for this exact confusion.
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit
TIDB_DECODE_SQL_DIGESTS()excludes literal value formats and arguments.?or....