i18n(ja): fix clause/statement label swaps in 4 files - #23671
Conversation
Fix genuine mistranslations where WHERE/GROUP BY/SELECT/id were mislabeled relative to their EN source (clause called statement, column called clause, or the wrong keyword given the "statement" label entirely): - dev-guide-update-data.md, dev-guide-delete-data.md: EN says "specify the WHERE clause in the UPDATE/DELETE statement", JA had the WHERE/ UPDATE (or WHERE/DELETE) statement/clause labels swapped. - functions-and-operators/miscellaneous-functions.md: EN says the first SELECT statement errors because the id column isn't in the GROUP BY clause; JA had scrambled all three labels (id called a clause, GROUP BY called a statement, SELECT called a column). - releases/release-7.0.0.md: EN says "a SELECT statement with filter conditions (WHERE clause)"; JA had merged SELECT and WHERE into one garbled compound and dropped the filter-conditions framing. Verified against upstream/release-8.5 for each site. A broader corpus scan for `WHERE`/`JOIN`/`ORDER BY`/`GROUP BY`+statement found 16 more sites across other files that turned out to be faithful renderings of EN's own "statement" wording for these clauses (EN itself uses this terminology loosely in many places) -- those are correctly left as-is.
ti-chi-bot
Bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughFour documentation statements were corrected. The changes update SQL best-practice wording, clarify the ChangesDocumentation corrections
Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: ⚪ Minimal · up to This PR corrects mislabeled SQL terminology and sentence structure in four Japanese documentation files without changing product behavior; no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Title checkExplanation The title clearly identifies the Japanese internationalization changes and the correction of clause/statement labels across four files. It also covers the primary nature of the changes, although one file includes broader wording corrections. Full details: Description checkExplanation The description explains the four documentation corrections, their source comparison, affected version, AI involvement, and unchanged related sites. The required change and version sections are completed. The reference-link fields are blank, but this is non-critical. Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (4 skipped: 4 unsupported.) ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ti-chi-bot
Bot
added
area/develop
ti-chi-bot
Bot
removed
the
do-not-merge/work-in-progress
qiancai
added
translation/no-need
[LGTM Timeline notifier]Timeline:
|
2 participants
What is changed, added or deleted? (Required)
Fixes genuine mistranslations (誤訳, not 表記揺れ) found while doing an unrelated statement-terminology
sweep (#23668). In 4 files, the JA translation swapped which SQL keyword is the "statement" and which
is the "clause" (or, in one case, mislabeled a column as a clause), diverging from what the EN source
actually says:
develop/dev-guide-update-data.md: EN says "Always specify theWHEREclause in theUPDATEstatement." JA had it backwards (
WHEREステートメント /UPDATE句) — fixed toUPDATEステートメント /WHERE句.develop/dev-guide-delete-data.md: same swap, EN says "Always specify theWHEREclause in theDELETEstatement." — fixed the same way.functions-and-operators/miscellaneous-functions.md: EN says "TiDB returns an error for the firstSELECTstatement because theidcolumn is non-aggregated and not included in theGROUP BYclause." JA had scrambled all three labels (
id句,GROUP BYステートメント,SELECT列) — fixed tomatch EN (
id列,GROUP BY句,SELECTステートメント).releases/release-7.0.0.md: EN says "When processing aSELECTstatement with filter conditions(
WHEREclause)..." JA had mergedSELECT/WHEREinto one garbled compound and dropped the"with filter conditions" framing — reworded to match EN's structure.
Each fix verified against
upstream/release-8.5before applying. A broader corpus scan for`WHERE`/`JOIN`/`ORDER BY`/`GROUP BY`immediately followed by "statement" found 16 more sitesacross other files (release notes, glossary.md, several
develop/guides, etc.) — those were allchecked individually and turned out to be faithful 1:1 renderings of the EN source, which itself
uses "statement" loosely for these clauses in many places. Those are intentionally left untouched.
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit
DELETEandUPDATEstatements withWHEREclauses.ANY_VALUE()function.