lake: improve CREATE DATABASE storage example, update a diagram#23255
Conversation
Reworked the `CREATE DATABASE` examples in TiDB Cloud Lake docs by splitting them into clearer sections and updating the default storage connection example to use an AWS IAM role instead of access keys. Added guidance about IAM role trust setup with a link to the authentication guide, and refreshed the related `staging-file.png` image.
lilin90
added
translation/no-need
ti-chi-bot
Bot
added
the
size/S
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the database creation documentation for TiDB Cloud Lake by adding subheadings, updating the S3 connection example to use a more secure AWS IAM role instead of access keys, and adding a note on setting up the trust relationship. The review feedback correctly identifies that the new subheadings should be updated to sentence case to comply with the repository's style guide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
@awxxxxxx: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lilin90 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 participants
What is changed, added or deleted? (Required)
Reworked the
CREATE DATABASEexamples in TiDB Cloud Lake docs by splitting them into clearer sections and updating the default storage connection example to use an AWS IAM role instead of access keys. Added guidance about IAM role trust setup with a link to the authentication guide.Refreshed the
staging-file.pngimage.Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?