hardware-and-software-requirements: Add note about supported filesystems (#21379) #21389
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot
added
do-not-merge/hold
|
@dveeden This PR has conflicts, I have hold it. |
|
@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
ti-chi-bot
bot
added
size/M
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @ti-chi-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily enhances the TiDB documentation by clarifying hardware and software requirements, specifically by adding a note about supported file systems (XFS and Ext4). It also renames the 'Disk space requirements' section to 'Storage requirements' and updates the TiDB component's entry in the hardware table to reference this new section. A critical observation is that this automated cherry-pick has committed unresolved merge conflict markers into both the .lycheeignore file and the hardware-and-software-requirements.md file, which will require manual intervention.
Highlights
- Documentation Update: Storage Requirements: The section previously titled 'Disk space requirements' has been renamed to 'Storage requirements'. Additionally, the TiDB component's 'Local Storage' entry in the hardware table now links to this updated section for more detailed information.
- Automated Cherry-Pick with Unresolved Conflicts: This pull request is an automated cherry-pick that appears to have committed merge conflict markers (
<<<<<<<,=======,>>>>>>>) directly into the.lycheeignorefile and thehardware-and-software-requirements.mdfile. These conflicts will need to be manually resolved.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request adds a note about supported filesystems (XFS and Ext4) to the hardware and software requirements documentation. It also updates a table to link to the storage requirements section.
My review has identified critical issues in both .lycheeignore and hardware-and-software-requirements.md where merge conflict markers have been committed. These need to be resolved. I've also left a minor suggestion to improve markdown formatting.
.lycheeignore
Outdated
| http://localhost:\d+/ | ||
| ======= | ||
| http://localhost:\d+/ | ||
| https://github\.com/\$user/(docs|docs-cn) | ||
| https://linux\.die\.net/man.* | ||
| https://dev\.mysql\.com/doc/.+/5.7/en/.* | ||
| https://dev\.mysql\.com/doc/.+/8\.0/en/.* | ||
| https://dev\.mysql\.com/doc/.+/8\.4/en/.* | ||
| https://dev\.mysql\.com/doc/[a-z\-]+/en/.* | ||
| https://dev\.mysql\.com/doc/relnotes/[a-z\-]+/en/.* | ||
| https://dev\.mysql\.com/doc/dev/mysql-server/.* | ||
| https://dev\.mysql\.com/downloads/.* | ||
| https://bugs\.mysql\.com/bug\.php.* | ||
| https://www\.mysql\.com/products/.* | ||
| https://platform\.openai\.com/docs/.* | ||
| https://openai\.com/.* | ||
| https://jwt\.io/ | ||
| https://typeorm\.io/.* | ||
| https://dash\.cloudflare\.com/.* | ||
| https://centminmod\.com/mydumper\.html | ||
| https://docs\.pingcap\.com/tidb/v6\.6/system-variables#tidb_pessimistic_txn_aggressive_locking-new-in-v660 | ||
| https://docs\.pingcap\.com/tidb/v7\.6/system-variables#tidb_ddl_version-new-in-v760 | ||
| https://developers\.redhat\.com/blog/2021/01/05/building-red-hat-enterprise-linux-9-for-the-x86-64-v2-microarchitecture-level | ||
| >>>>>>> 21916eefd3 (hardware-and-software-requirements: Add note about supported filesystems (#21379)) |
There was a problem hiding this comment.
This file contains Git merge conflict markers (<<<<<<<, =======, >>>>>>>). These markers must be removed for the file to be parsed correctly.
http://localhost:\d+/
https://github\.com/\$user/(docs|docs-cn)
https://linux\.die\.net/man.*
https://dev\.mysql\.com/doc/.+/5.7/en/.*
https://dev\.mysql\.com/doc/.+/8\.0/en/.*
https://dev\.mysql\.com/doc/.+/8\.4/en/.*
https://dev\.mysql\.com/doc/[a-z\-]+/en/.*
https://dev\.mysql\.com/doc/relnotes/[a-z\-]+/en/.*
https://dev\.mysql\.com/doc/dev/mysql-server/.*
https://dev\.mysql\.com/downloads/.*
https://bugs\.mysql\.com/bug\.php.*
https://www\.mysql\.com/products/.*
https://platform\.openai\.com/docs/.*
https://openai\.com/.*
https://jwt\.io/
https://typeorm\.io/.*
https://dash\.cloudflare\.com/.*
https://centminmod\.com/mydumper\.html
https://docs\.pingcap\.com/tidb/v6\.6/system-variables#tidb_pessimistic_txn_aggressive_locking-new-in-v660
https://docs\.pingcap\.com/tidb/v7\.6/system-variables#tidb_ddl_version-new-in-v760
https://developers\.redhat\.com/blog/2021/01/05/building-red-hat-enterprise-linux-9-for-the-x86-64-v2-microarchitecture-level
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
ti-chi-bot
bot
added
size/S
qiancai
removed
the
do-not-merge/hold
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiancai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #21379
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?