release-8.1: Support STATEMENTS_SUMMARY_HISTORY & limit tidb_analyze_skip_column_types for serverless
#21378
Conversation
…olumn_types for serverless Signed-off-by: Ping Yu <[email protected]>
Signed-off-by: Ping Yu <[email protected]>
ti-chi-bot
bot
added
missing-translation-status
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @pingyu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the TiDB Cloud documentation to reflect changes in feature availability and configuration for TiDB Serverless. It specifically enables support for STATEMENTS_SUMMARY_HISTORY and restricts the tidb_analyze_skip_column_types variable to read-only access within the serverless environment.
Highlights
- STATEMENTS_SUMMARY_HISTORY Support: Enabled
STATEMENTS_SUMMARY_HISTORYfor TiDB Serverless, updating its status in the documentation from 'Not supported' to 'Supported'. tidb_analyze_skip_column_typesLimitation: Documentedtidb_analyze_skip_column_typesas a read-only variable for TiDB Serverless.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates the documentation for TiDB Cloud to reflect new support for STATEMENTS_SUMMARY_HISTORY and a new read-only limitation for tidb_analyze_skip_column_types in TiDB Serverless. The changes in tidb-cloud/limited-sql-features.md are accurate. I've also suggested an additional documentation update in another file to maintain consistency.
|
@sunxiaoguang: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Oreoxmt
added
area/tidb-cloud
ti-chi-bot
bot
removed
the
missing-translation-status
Oreoxmt
added
the
needs-cherry-pick-release-8.5
[LGTM Timeline notifier]Timeline:
|
Oreoxmt
added
do-not-merge/hold
|
This PR is going to conflict with the release-cloud branch. Another PR has been created for the release-cloud branch. |
Oreoxmt
added
cherry-pick-release-cloud/no-need
|
/unhold |
|
/approve |
ti-chi-bot
bot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Oreoxmt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
In response to a cherrypick label: new pull request created to branch |
First-time contributors' checklist
What is changed, added or deleted? (Required)
STATEMENTS_SUMMARY_HISTORY.tidb_analyze_skip_column_typesas read only for TiDB ServerlessWhich TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?