offline 6tb tikv disk #21194
offline 6tb tikv disk #21194
Conversation
* This is an automated cherry-pick of pingcap#19612 Signed-off-by: ti-chi-bot <[email protected]> * Resolve conflict * Resolve conflict --------- Signed-off-by: ti-chi-bot <[email protected]> Co-authored-by: Suhaha <[email protected]> Co-authored-by: Lilian Lee <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
offline tikv 6tb disk
ti-chi-bot
bot
added
contribution
|
Hi @jinwhu. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
ti-chi-bot
bot
added
area/develop
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
the
size/XXL
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @jinwhu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request represents a major documentation overhaul, aiming to align the TiDB documentation with the latest product versions, enhance user experience by improving content organization and consistency, and provide detailed guides for new and existing features across both TiDB Cloud and TiDB Self-Managed offerings. The changes are extensive and touch upon nearly all aspects of the product's usage and administration.
Highlights
- Documentation Restructuring: The entire documentation structure for both TiDB Cloud and TiDB Self-Managed has been significantly reorganized, introducing new top-level sections and logical groupings for improved navigation and clarity. This includes dedicated sections for 'GET STARTED', 'DEVELOP', 'GUIDES', 'REFERENCE', and 'RELEASES' in TiDB Cloud, and similar improvements for TiDB Self-Managed.
- Terminology Standardization: Consistent renaming has been applied across numerous files, changing 'TiDB Serverless' to 'TiDB Cloud Serverless' and 'TiDB Self-Hosted' to 'TiDB Self-Managed', ensuring a unified and clear terminology throughout the documentation.
- New Feature Documentation: Extensive new content has been added for TiDB Cloud, specifically detailing 'Vector Search' capabilities, expanded 'Data Service' functionalities, and a comprehensive update to CLI commands. For TiDB Self-Managed, new sections cover security best practices, detailed TiDB Dashboard monitoring, and advanced SQL features.
- SQL and System Function Enhancements: Updates include refined behavior for
AUTO_INCREMENT, a complete overhaul and categorization ofJSONfunctions into dedicated sub-sections, and the introduction of new TiDB-specific functions likeTIDB_CURRENT_TSO()andTIDB_DECODE_BINARY_PLAN(). - Tooling and Operational Updates: The documentation for
BR(Backup & Restore) andDM(Data Migration) has been updated with new compatibility matrices, performance metrics, and security enhancements. Operational guides now include detailed information on managing system swap, SELinux, and dynamic configuration updates for TiKV.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request includes several updates to the documentation, including adding links to documentation for version 8.1, updating the OWNERS file, and reorganizing the table of contents for TiDB Cloud. The changes generally improve the documentation's accuracy and organization. The style guide was followed, and suggestions were made to improve clarity and consistency.
| https://dev\.mysql\.com/doc/.+/5.7/en/.* | ||
| https://dev\.mysql\.com/doc/.+/8\.0/en/.* | ||
| https://dev\.mysql\.com/doc/.+/8\.4/en/.* | ||
| https://dev\.mysql\.com/doc/[a-z\-]+/en/.* | ||
| https://dev\.mysql\.com/doc/relnotes/[a-z\-]+/en/.* | ||
| https://dev\.mysql\.com/doc/dev/mysql-server/.* | ||
| https://dev\.mysql\.com/downloads/.* | ||
| https://bugs\.mysql\.com/bug\.php.* | ||
| https://www\.mysql\.com/products/.* | ||
| https://platform\.openai\.com/docs/.* | ||
| https://openai\.com/.* | ||
| https://jwt\.io/ | ||
| https://typeorm\.io/.* | ||
| https://dash\.cloudflare\.com/.* | ||
| https://centminmod\.com/mydumper\.html | ||
| https://docs\.pingcap\.com/tidb/v6\.6/system-variables#tidb_pessimistic_txn_aggressive_locking-new-in-v660 | ||
| https://docs\.pingcap\.com/tidb/v7\.6/system-variables#tidb_ddl_version-new-in-v760 |
There was a problem hiding this comment.
This change adds several URLs to the ignore list. It would be helpful to add a brief description or comment explaining why these URLs are being ignored, for future maintainability. This is in line with the style of the file, and the documentation review style guide (lines 14-16) emphasizes clarity and maintainability.
+https://github\.com/\$user/(docs|docs-cn)
+# Ignore list for various reasons (e.g., redirects, dynamic content)
+https://linux\.die\.net/man.*
Style Guide References
| emeritus_approvers: | ||
| - CaitinChen | ||
| - CharLotteiu | ||
| - cofyc | ||
| - DanielZhangQD | ||
| - dcalvin | ||
| - dragonly | ||
| - en-jin19 | ||
| - lichunzhu | ||
| - Liuxiaozhen12 | ||
| - morgo | ||
| - queenypingcap | ||
| - ran-huang | ||
| - shichun-0415 | ||
| - SunRunAway | ||
| - tangenta | ||
| - TomShawn | ||
| - toutdesuite | ||
| - WangXiangUSTC |
There was a problem hiding this comment.
This change moves several approvers to emeritus_approvers. It would be helpful to add a comment explaining why these approvers are being moved to emeritus status. This enhances maintainability and provides context for future changes.
+emeritus_approvers:
+ # Moved to emeritus status per policy.
+ - CaitinChen
| - [TiDB Cloud Introduction](/tidb-cloud/tidb-cloud-intro.md) | ||
| - [MySQL Compatibility](/mysql-compatibility.md) |
There was a problem hiding this comment.
According to the style guide (lines 32-33), headings should be in sentence case. Consider changing "Why TiDB Cloud" to "Why TiDB Cloud" to follow this guideline.
Style Guide References
| - [TiDB Cloud Introduction](/tidb-cloud/tidb-cloud-intro.md) | |
| - [MySQL Compatibility](/mysql-compatibility.md) | |
| 8:- Why TiDB Cloud | |
| 9: - [TiDB Cloud Introduction](/tidb-cloud/tidb-cloud-intro.md) |
| - Get Started with TiDB Cloud | ||
| - [Try Out TiDB Cloud Serverless](/tidb-cloud/tidb-cloud-quickstart.md) | ||
| - [Try Out TiDB + AI](/tidb-cloud/vector-search-get-started-using-python.md) |
There was a problem hiding this comment.
According to the style guide (lines 32-33), headings should be in sentence case. Consider changing "Get Started with TiDB Cloud" to "Get started with TiDB Cloud" to follow this guideline.
Style Guide References
| - Get Started with TiDB Cloud | |
| - [Try Out TiDB Cloud Serverless](/tidb-cloud/tidb-cloud-quickstart.md) | |
| - [Try Out TiDB + AI](/tidb-cloud/vector-search-get-started-using-python.md) | |
| 10:- Get Started with TiDB Cloud | |
| 11: - [Try Out TiDB Cloud Serverless](/tidb-cloud/tidb-cloud-quickstart.md) |
| - [Connect via Public Connection](/tidb-cloud/connect-via-standard-connection.md) | ||
| - [Connect via Private Endpoint with AWS](/tidb-cloud/set-up-private-endpoint-connections.md) |
There was a problem hiding this comment.
According to the style guide (lines 32-33), headings should be in sentence case. Consider changing "Connect via Public Connection" to "Connect via Public connection" to follow this guideline.
Style Guide References
| - [Connect via Public Connection](/tidb-cloud/connect-via-standard-connection.md) | |
| - [Connect via Private Endpoint with AWS](/tidb-cloud/set-up-private-endpoint-connections.md) | |
| 156: - Connect to Your TiDB Cloud Dedicated Cluster | |
| 157: - [Connect via Public Connection](/tidb-cloud/connect-via-standard-connection.md) |
| - Explore Data | ||
| - [Chat2Query (Beta)](/tidb-cloud/explore-data-with-chat2query.md) | ||
| - Data Service (Beta) | ||
| - [Chat2Query in SQL Editor](/tidb-cloud/explore-data-with-chat2query.md)  |
There was a problem hiding this comment.
It seems like there's a missing space before the ![BETA] tag. Adding a space would improve readability.
| - [Chat2Query in SQL Editor](/tidb-cloud/explore-data-with-chat2query.md)  | |
| 280: - [Chat2Query in SQL Editor](/tidb-cloud/explore-data-with-chat2query.md)  |
| - Data Access Control | ||
| - [Encryption at Rest Using Customer-Managed Encryption Keys](/tidb-cloud/tidb-cloud-encrypt-cmek.md) | ||
| - Database Access Control | ||
| - [Configure Cluster Security Settings](/tidb-cloud/configure-security-settings.md) | ||
| - [Configure Cluster Password Settings](/tidb-cloud/configure-security-settings.md) |
There was a problem hiding this comment.
According to the style guide (lines 32-33), headings should be in sentence case. Consider changing "Configure Cluster Password Settings" to "Configure cluster password settings" to follow this guideline.
Style Guide References
| - [Configure Cluster Password Settings](/tidb-cloud/configure-security-settings.md) | |
| 362: - Database Access Control | |
| 363: - [Configure Cluster Password Settings](/tidb-cloud/configure-security-settings.md) |
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?