Skip to content

clinic: list audit logs as included in diag #21129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 4, 2025
Merged

clinic: list audit logs as included in diag #21129

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fd177f8
clinic: list audit logs as included in diag
dveeden Jun 5, 2025
ec34411
Merge remote-tracking branch 'upstream/master' into clinic_diag_auditlog
dveeden Jun 10, 2025
0deb8fb
Add logtype detail
dveeden Jun 10, 2025
03a24d7
Add suffix for rocksdb log type
dveeden Jun 12, 2025
88f1dc9
Apply suggestions from code review
dveeden Jun 20, 2025
e81a062
Update clinic/clinic-data-instruction-for-tiup.md
dveeden Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions clinic/clinic-data-instruction-for-tiup.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ This section lists the types of diagnostic data that can be collected by [Diag](
| Log | `tidb.log` | `--include=log` |
| Error log | `tidb_stderr.log` | `--include=log` |
| Slow log | `tidb_slow_query.log` | `--include=log` |
| Audit Logs | `tidb-audit.log.json` | `--include=log` |
Copy link
Collaborator

@qiancai qiancai Jul 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dveeden just double check, in tidb-audit.log.json, whether .json is needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that's how the files are named.

| Configuration file | `tidb.toml` | `--include=config` |
| Real-time configuration | `config.json` | `--include=config` |

Expand Down