Skip to content

pd: complement pd section #20500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 23, 2025
Merged

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Jun 12, 2025

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Signed-off-by: Ryan Leung <[email protected]>
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 12, 2025
Copy link

ti-chi-bot bot commented Jun 12, 2025

@lhy1024: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rleungx rleungx requested a review from qiancai June 16, 2025 08:16
Copy link

ti-chi-bot bot commented Jun 17, 2025

@BornChanger: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@qiancai
Copy link
Collaborator

qiancai commented Jun 18, 2025

/bot-review

Copy link

✅ AI review completed, 2 comments generated.

@pingcap pingcap deleted a comment from github-actions bot Jun 18, 2025
@pingcap pingcap deleted a comment from github-actions bot Jun 18, 2025
| schedule.hot-regions-write-interval | 设置 PD 存储 Hot Region 信息时间间隔 |
| schedule.hot-regions-reserved-days | 设置 PD 保留的 Hot Region 信息的最长时间 |
| schedule.max-movable-hot-peer-size | 设置热点调度可以调度的最大 Region size |
| schedule.store-limit-version | 设置 store limit 工作模式 |
Copy link
Collaborator

@qiancai qiancai Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| schedule.store-limit-version | 设置 store limit 工作模式 |
| schedule.store-limit-version | 设置 [store limit](/configure-store-limit.md) 工作模式 |

| pd-server.use-region-storage | 开启独立的 Region 存储 |
| pd-server.max-gap-reset-ts | 用于设置最大的重置 timestamp 的间隔(BR)|
| pd-server.key-type| 用于设置集群 key 的类型 |
| pd-server.metric-storage | 用于设置集群 metrics 的存储地址 |
| pd-server.dashboard-address | 用于设置 dashboard 的地址 |
| pd-server.flow-round-by-digit | PD 会对流量信息的末尾数字进行四舍五入处理,减少 Region 流量信息变化引起的统计信息更新 |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| pd-server.flow-round-by-digit | PD 会对流量信息的末尾数字进行四舍五入处理,减少 Region 流量信息变化引起的统计信息更新 |
| pd-server.flow-round-by-digit | 指定 PD Region 流量信息的末尾数字进行四舍五入的位数 |

Comment on lines 329 to 330
| replication-mode.dr-auto-sync.primary-replicas | 是主 AZ 上 Voter 副本的数量 |
| replication-mode.dr-auto-sync.dr-replicas | 是从 AZ 上 Voter 副本的数量 |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| replication-mode.dr-auto-sync.primary-replicas | 是主 AZ 上 Voter 副本的数量 |
| replication-mode.dr-auto-sync.dr-replicas | 是从 AZ 上 Voter 副本的数量 |
| replication-mode.dr-auto-sync.primary-replicas | AZ 上 Voter 副本的数量 |
| replication-mode.dr-auto-sync.dr-replicas | AZ 上 Voter 副本的数量 |

Comment on lines 332 to 333
| replication-mode.dr-auto-sync.wait-recover-timeout | 当网络恢复后,切换回 sync-recover 状态的等待时间 |
| replication-mode.dr-auto-sync.pause-region-split | 用于控制在 async_wait 和 async 状态下是否暂停 Region 的 split 操作 |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| replication-mode.dr-auto-sync.wait-recover-timeout | 当网络恢复后,切换回 sync-recover 状态的等待时间 |
| replication-mode.dr-auto-sync.pause-region-split | 用于控制在 async_wait 和 async 状态下是否暂停 Region 的 split 操作 |
| replication-mode.dr-auto-sync.wait-recover-timeout | 当网络恢复后,切换回 `sync-recover` 状态的等待时间 |
| replication-mode.dr-auto-sync.pause-region-split | 用于控制在 `async_wait``async` 状态下是否暂停 Region 的 split 操作 |

@qiancai qiancai self-assigned this Jun 18, 2025
@qiancai qiancai added the translation/doing This PR’s assignee is translating this PR. label Jun 18, 2025
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Jun 18, 2025
rleungx added 2 commits June 19, 2025 11:39
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 19, 2025
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@@ -307,6 +307,12 @@ pd-server 相关配置项。
+ 控制对同一个 Region 做 split 和 merge 操作的间隔,即对于新 split 的 Region 一段时间内不会被 merge。
+ 默认:1h

### `max-movable-hot-peer-size`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### `max-movable-hot-peer-size`
### `max-movable-hot-peer-size` <span class="version-mark">从 v7.1.0 版本开始引入</span>

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 19, 2025
Copy link

ti-chi-bot bot commented Jun 19, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-06-19 09:42:15.404782927 +0000 UTC m=+351188.127961910: ☑️ agreed by qiancai.

rleungx added 3 commits June 19, 2025 18:23
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
@qiancai qiancai added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels Jun 20, 2025
@qiancai
Copy link
Collaborator

qiancai commented Jun 23, 2025

/approve

@qiancai qiancai added the lgtm label Jun 23, 2025
Copy link

ti-chi-bot bot commented Jun 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jun 23, 2025
@qiancai qiancai added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. approved labels Jun 23, 2025
@ti-chi-bot ti-chi-bot bot added the approved label Jun 23, 2025
Copy link

ti-chi-bot bot commented Jun 23, 2025

@qiancai: You cannot manually add or delete the cherry pick approval state labels, only I and the tursted members have permission to do so. You can approve it in internal platform.

In response to removing label named approved.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit ed496dc into pingcap:master Jun 23, 2025
7 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #20536.
But this PR has conflicts, please resolve them!

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Jun 23, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #20537.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #20538.
But this PR has conflicts, please resolve them!

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Jun 23, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #20539.
But this PR has conflicts, please resolve them!

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants