Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: google vertex llm #599

Merged
merged 6 commits into from
Jan 25, 2025
Merged

feat: google vertex llm #599

merged 6 commits into from
Jan 25, 2025

Conversation

jrj5423
Copy link
Collaborator

@jrj5423 jrj5423 commented Jan 16, 2025

Close #523.

Considering that our current llama_index can already support Vertex, should we merge ANTHROPIC_VERTEX into the same type as VERTEX in this commit?

Copy link

vercel bot commented Jan 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tidb-ai-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 25, 2025 10:13am
tidb-ai-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 25, 2025 10:13am

Copy link

vercel bot commented Jan 16, 2025

@jrj5423 is attempting to deploy a commit to the pingcap Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@Mini256 Mini256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the ANTHROPIC_VERTEX for compatibility, we will delete it in the feature.

Please also support dsp.GoogleVertexAI on dspy LM

raise ValueError("Vertex is not supported by dspy.")

@@ -132,6 +133,22 @@ class LLMProviderOption(BaseModel):
"private_key_id": "****",
},
),
LLMProviderOption(
Copy link
Member

@Mini256 Mini256 Jan 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename the provider name of ANTHROPIC_VERTEX option to Anthropic Vertex AI (Deprecated)

@@ -8,6 +8,7 @@ class LLMProvider(str, enum.Enum):
OPENAI = "openai"
GEMINI = "gemini"
ANTHROPIC_VERTEX = "anthropic_vertex"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the LLMProvider.ANTHROPIC_VERTEX enumeration to avoid errors for users who are already using it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is probably only us who are using ANTHROPIC_VERTEX, so I suggest to delete it in the code. we(tidb.ai) can re-configure it in production environment.

@Mini256 Mini256 merged commit 3abfe48 into pingcap:main Jan 25, 2025
14 of 20 checks passed
NG85 pushed a commit to NG85/autoflow that referenced this pull request Feb 7, 2025
Close pingcap#523.

Considering that our current `llama_index` can already support `Vertex`,
should we merge `ANTHROPIC_VERTEX` into the same type as `VERTEX` in
this commit?

---------

Co-authored-by: Mini256 <[email protected]>
Mini256 added a commit to sszgwdk/autoflow that referenced this pull request Feb 11, 2025
Close pingcap#523.

Considering that our current `llama_index` can already support `Vertex`,
should we merge `ANTHROPIC_VERTEX` into the same type as `VERTEX` in
this commit?

---------

Co-authored-by: Mini256 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core(llm): support Google Vertex AI
3 participants