Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Update embedder #16

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[WIP] Update embedder #16

wants to merge 2 commits into from

Conversation

zackproser
Copy link
Collaborator

@zackproser zackproser commented Nov 3, 2023

Problem

Describe the purpose of this change. What problem is being solved and why?

THIS IS CURRENTLY FAILING

It seems the model we're using expects 768 dimensions, even though we've intentionally updated our index to be 384. Per our discussion, I updated my test Pinecone index to be 384 dimensions.

 PineconeBadRequestError: Query vector dimension 768 does not match the dimension of the index 384
    at mapHttpStatusError (webpack-internal:///(rsc)/./node_modules/@pinecone-database/pinecone/dist/errors/http.js:179:20)
    at eval (webpack-internal:///(rsc)/./node_modules/@pinecone-database/pinecone/dist/errors/handling.js:170:55)
    at step (webpack-internal:///(rsc)/./node_modules/@pinecone-database/pinecone/dist/errors/handling.js:107:23)
    at Object.eval [as next] (webpack-internal:///(rsc)/./node_modules/@pinecone-database/pinecone/dist/errors/handling.js:48:20)
    at fulfilled (webpack-internal:///(rsc)/./node_modules/@pinecone-database/pinecone/dist/errors/handling.js:11:32)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
  cause: undefined

This PR rebases the update-embedder branch onto main, which recently received fixes for the Docker build that was failing due to Alpine linux issues: #15

We still need to sort through this dimension mismatch.

Solution

Describe the approach you took. Link to any relevant bugs, issues, docs, or other resources.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

Describe specific steps for validating this change.

@zackproser zackproser requested a review from rschwabco November 3, 2023 22:37
@zackproser
Copy link
Collaborator Author

@rschwabco FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant