Add progress bars for main phases #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use vsb.logger instead of the global 'logging' methods, as we only show messages from the vsb logger to stdout (everything still goes to the vsg.log file).
Add a new VectorWorkload.request_count property to all workloads, which specified how many requests are in the query dataset. This will be used to show a progress bar for the Run phase - the MasterRunner needs to know the total number of requests for the progress bar's denominator.
daverigby
force-pushed
the
progressbars
branch
2 times, most recently
from
7490de6 to
5691131
Compare
Add progress bars for each of the main phases of an experiment -
Setup, Populate and Run. For Populate and Run we require the total
number of records / queries to show a useful end progress so far.
For the Populate phase we include the current rate of upsert. For the
Run phase we include the current latency and recall(*) values, these
require additional metrics of how many records have been upserted so
far (note that we generally upsert in batches, so the existing number
of Population requests is not sufficient.
(*) For recall we cannot calculate the current metric (last 10s), as
we only have a single histogram accumulating the results - instead
this shows the overall recall so far. There's an improvement
raised to fix this (#108).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add progress bars for each of the main phases of an experiment -
Setup, Populate and Run. For Populate and Run we require the total
number of records / queries to show a useful end progress so far.
For the Run phase we include the current latency and recall(*) values,
these require additional metrics of how many records have been
upserted so far (note that we generally upsert in batches, so the
existing number of Population requests is not sufficient.
(*) For recall we cannot calculate the current metric (last 10s), as
we only have a single histogram accumulating the results - instead
this shows the overall recall so far. There's an improvement
raised to fix this (#108).
Fixes #44.