Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

From https://github.com/kutuluk/log-n-roll #120

Closed
wants to merge 1 commit into from
Closed

From https://github.com/kutuluk/log-n-roll #120

wants to merge 1 commit into from

Conversation

kutuluk
Copy link
Contributor

@kutuluk kutuluk commented Feb 13, 2018

@pimterry
Copy link
Owner

Great work, thanks for this, sorry I haven't replied, my week's been a bit hectic.

I'm definitely going to pull in the overall design from here, and sections of the code itself too, but I'm not going to merge this PR. Right now this just copies in your repo over the top of the existing setup. Your changes to the core code do look great, but that also completely removes all the existing project infrastructure etc (this is part of why the build is failing), and I'd quite like to keep as much of that in place as possible for the moment.

I do definitely also want to update some of that in future too, but incrementally, rather than trying to rereview and rebuild everything from scratch in one go.

I'm going to close this for now - I've got a working version of the source based on your changes running locally, and I'm going to build a small incremental PR using that once I've got tested sorted, and then I'd love your feedback! I'll open a PR with that soon.

@pimterry pimterry closed this Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants