Added error handling to schedule tab #1014
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corepex
commented
Feb 18, 2025
Comment on lines
-77
to
+87
| if (isLoading || data === undefined) { | ||
| return <Content loading /> | ||
| } | ||
|
|
||
| if (isError) { | ||
| trackError(new ApiError(error)) | ||
| return <div>Error</div> | ||
| } | ||
|
|
||
| if (isLoading || data === undefined) { | ||
| return <Content loading /> | ||
| } | ||
|
|
There was a problem hiding this comment.
@markus-moser, as you see here, I moved the isError condition above the isLoading condition since rtk doesn't reset the isLoading when an error is thrown.
This leads to the behavior that now "error" appears in the tab instead of an infinite loading spinner ... Should we define an "error view" similar to the empty content or loading view?
WDYT
There was a problem hiding this comment.
Yes I would go for an error view where we show the error message instead - maybe a simple (and then remove the default handling with the alert).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Resolves #971
Additional info
This pull request includes changes to improve error handling in the
VersionIdCellandScheduleTabContainercomponents by adding error tracking and handling mechanisms. The most important changes include adding imports for the error handling utilities and modifying the components to track and handle errors appropriately.Error handling improvements:
assets/js/src/core/modules/element/dynamic-types/defintinitions/grid-cell/components/_schedule/version-id-cell/version-id-cell.tsx: Added imports fortrackErrorandApiError, and modified theVersionIdCellcomponent to track errors using these utilities.assets/js/src/core/modules/element/editor/shared-tab-manager/tabs/schedule/schedule-container.tsx: Added imports fortrackErrorandApiError, and modified theScheduleTabContainercomponent to track errors using these utilities. [1] [2] [3]