Skip to content

[Improvement] Add element type to the getIds method of ElementSearchResult #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2024
Merged

[Improvement] Add element type to the getIds method of ElementSearchResult #230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Model/Search/Element/SearchResult/ElementSearchResult.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,10 @@ public function getAggregation(string $aggregationName): ?SearchResultAggregatio
public function getIds(): array
{
return array_map(
static fn (ElementSearchResultItemInterface $item) => $item->getId(),
static fn (ElementSearchResultItemInterface $item) => [
'id' => $item->getId(),
'elementType' => $item->getElementType()->value,
],
$this->items
);
}
Expand Down
14 changes: 12 additions & 2 deletions tests/Functional/Search/Modifier/Filter/DependencyFiltersTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,13 +74,23 @@ public function testDependencyFilters()
->addModifier(new RequiredByFilter($object1->getId(), ElementType::DATA_OBJECT))
;
$searchResult = $searchService->search($elementSearch);
$this->assertIdArrayEquals([$object4->getId()], $searchResult->getIds());

$this->assertIdArrayEquals(
[['id' => $object4->getId(), 'elementType' => ElementType::DATA_OBJECT->value]],
$searchResult->getIds()
);

$elementSearch = $searchProvider
->createElementSearch()
->addModifier(new RequiresFilter($object1->getId(), ElementType::DATA_OBJECT));
$searchResult = $searchService->search($elementSearch);
$this->assertIdArrayEquals([$object2->getId(), $object3->getId()], $searchResult->getIds());
$this->assertIdArrayEquals(
[
['id' => $object2->getId(), 'elementType' => ElementType::DATA_OBJECT->value],
['id' => $object3->getId(), 'elementType' => ElementType::DATA_OBJECT->value],
],
$searchResult->getIds()
);
}

private function assertIdArrayEquals(array $ids1, array $ids2)
Expand Down
Loading