Skip to content

Upgrade actions CI workflow #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025
Merged

Upgrade actions CI workflow #361

merged 1 commit into from
Apr 29, 2025

Conversation

blakeembrey
Copy link
Member

Current action is failing on Missing download info for actions/cache@v2. There's some cache built into the newer setup-node, but the dependency caching doesn't make much difference for overall test perf to warrant trying to keep it in the workflow.

@ctcpip
Copy link
Member

ctcpip commented Apr 29, 2025

I know we sometimes disagree on what a 'trivial' change is, but this seems trivial enough to me to merge. But @blakeembrey requested reviews explicitly from three TC members. Was there some particular aspect of this that needs extra scrutiny?

@blakeembrey
Copy link
Member Author

this seems trivial enough to me to merge

I thought the trivial was only for the 36 hour wait, but I was just going to always wait to avoid an accidental non-trivial merge.

Since I am the only maintainer/captain I think the only approvals can come from another TC member. There isn't yet a TC reviewer tag so I just added a few people who might want to review it. No specific reason for 3 other than ensuring a review. Is there a preferred way to do this now?

@blakeembrey blakeembrey merged commit ed36cc2 into master Apr 29, 2025
4 checks passed
@ctcpip
Copy link
Member

ctcpip commented Apr 29, 2025

There isn't yet a TC reviewer tag

this is an annoying GH behavior. we need to add the TC team explicitly as collaborators on this repo with write access in order to be able to tag it for review

@blakeembrey blakeembrey deleted the be/upgrade-actions branch April 29, 2025 22:21
@wesleytodd
Copy link
Member

I think someone, maybe @UlisesGascon?, started adding a fast track label on things. Should we consider codifying that somewhere? Not a big deal either way as fixing CI is surely trivial.

@ctcpip
Copy link
Member

ctcpip commented Apr 30, 2025

@wesleytodd you may be thinking of the CPC concept

@wesleytodd
Copy link
Member

Yeah same concept I think but I mean specifically like here: expressjs/express#6336

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants