Skip to content

preserve cookie options when re-signing with rotated keys#183

Open
raashish1601 wants to merge 1 commit into
pillarjs:masterfrom
raashish1601:codex/22-cookie-signatures-lose-attributes-upon-re-signing-causin
Open

preserve cookie options when re-signing with rotated keys#183
raashish1601 wants to merge 1 commit into
pillarjs:masterfrom
raashish1601:codex/22-cookie-signatures-lose-attributes-upon-re-signing-causin

Conversation

@raashish1601

Copy link
Copy Markdown

What changed

  • Rework signed-cookie handling so generated .sig values carry serialized options (path/domain/maxAge/expires/etc) with an options signature.
  • On get/refresh path, verify and reuse those options when re-signing with a newer key, so attributes are preserved.
  • Add regression test for persistent cookie attribute retention after key rotation.
  • Update express tests for .sig cookie content format changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant