[highlights] fix highlights lexers - #1157
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ba3932f407
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hangs and quadratic scans
Fresh local stress-test timings on roughly 256 KB inputs:
;f(chains}}#{$xexpansions$"…"strings<!DOCTYPE [...]>subsetHighlighting fixes
<Select<Option> />and distinguish generic arrows such as<T extends X>(…)and<const T,>(…)from JSX.using,accessor, andasserts. Atemplate:property selects embedded markup only when its contents look like markup.{…}expressions, including across streamed lines; fix Vue interpolation boundaries.<style lang="scss|sass|less">selects the corresponding CSS dialect.rust,ignore,js{4}), intraword underscores, emphasis containing code spans, and fences inside block quotes. MDX import/export blocks follow JavaScript lexical state.${{ … }}, spaces, commas, and embedded brackets in plain scalars; recognize numeric and escaped quoted keys; allow comments after block-scalar headers such as| # comment.Performance
Combined tokenization time is approximately 4% lower across two local A/B runs of the language samples, each repeated to at least 256 KiB. These measurements use the raw Wasm record-output mode.
Small differences are sensitive to benchmark noise. Improvements include single-pass framework expressions, lazy JSX/signature checks, shared scanners, and cheaper byte-set checks.
Size and memory
languages.wat; generate Markdown fence lookup from the same registry.Intentional behavior changes
/* c */ #define X, the#is now an operator because another non-whitespace byte precedes it on the same line.COUNT (*)is no longer highlighted as a function call;COUNT(*)still is.Self::new()usefunction; dot calls such asvalue.method()retainfunction.method.