Conversation
Visitors now see focused product copy, an editable TSX example, and a second playground for exploring the full language catalog. Split the playground into hero and language variants, add responsive controls and language icons, and keep theme previews editable in place. Co-authored-by: Cursor <cursoragent@cursor.com>
Visitors can compare large-file throughput, process memory, themed token performance, and live-edit latency directly on the Highlights page. Present the published measurements with accessible figures and link the methodology beside concise notes about scales and test conditions. Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Keep the hero's supporting copy focused on the package source by removing the language count and benchmark methodology link. Co-authored-by: Cursor <cursoragent@cursor.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: be3e5e40da
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| {FEATURED_LANGUAGES.map((lang) => { | ||
| const { icon, color } = FEATURED_LANGUAGE_ICONS[lang]; | ||
| const selected = language === lang; | ||
| const maskImage = `url("${icon}")`; |
There was a problem hiding this comment.
When this client component is bundled by Next, a static SVG import resolves to image metadata rather than a URL string. Interpolating icon therefore produces url("[object Object]"), so all five featured-language masks are invalid and their icons disappear. Construct the mask from the imported asset's src value, or import the SVGs through a loader that explicitly returns URLs.
Useful? React with 👍 / 👎.
| const largeFileResults = [ | ||
| { | ||
| language: 'TypeScript', | ||
| size: '517 KB', |
There was a problem hiding this comment.
These values are copied numerically from packages/highlights/benchmark/README.md, where fixture sizes are reported in KiB, memory in MiB, and throughput in MiB/s, but the new page labels them as KB, MB, and MB/s without conversion. For example, the source result is 517 KiB rather than 517 KB; the same mismatch affects the memory chart and both token-throughput cards. Use the original binary units or convert the numeric values so the published benchmark evidence is not misrepresented.
Useful? React with 👍 / 👎.
This branch was successfully deployed
1 participant
Summary
Verification
moon run root:format root:lintmoonx docs:typecheckmoonx docs:testgit diff --check