Improve editor tokenizer performance and benchmarking - #1028
Open
ije wants to merge 3 commits into
Open
Conversation
Large files could synchronously build grammar state, remap cached states, and scan bracket caches during edits, delaying editor updates. Time-slice state prebuilds, remap comparison states lazily, and truncate the bracket cache in constant time. Scope background messages per tokenizer and ignore unchanged theme notifications. Add repeatable benchmarks and regression coverage for these paths.
…nchmarkEditorPieceTable.ts`
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 835816319b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
necolas
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Large files could synchronously build grammar state, remap cached states, and scan bracket caches during edits, delaying editor updates.
Time-slice state prebuilds, remap comparison states lazily, and truncate the bracket cache in constant time. Scope background messages per tokenizer and ignore unchanged theme notifications.
Add repeatable benchmarks and regression coverage for these paths.
Benchmark results
100,000 lines, 10 measured runs, 3 warmups; median timed-call latency:
Deep prebuild still performs the required grammar work, but distributes it across queued chunks instead of blocking the initiating call.
No-op theme updates now perform zero background restarts, theme applications, or callbacks. Background messages now trigger only their owning tokenizer.