Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many changes, fixes etc #26

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Many changes, fixes etc #26

wants to merge 24 commits into from

Conversation

Junker
Copy link

@Junker Junker commented Mar 26, 2018

No description provided.

@pierre-vigier
Copy link
Owner

After trying with you version, i have several issue, especially with the search bar plugin.
If i click outside of the search box, i can't serach anymore, there's also a white box on top of the list, what was the issue with the original search box?

Before:
screen shot 2018-03-26 at 14 32 17

After:
screen shot 2018-03-26 at 14 33 46
screen shot 2018-03-26 at 14 34 24

There is that empty space where the search box was previously and once i enter the search box, the cancel button does not work, if i touch outside of the the search box, i can't click in it anymore

What was the rational of replacing the old behaviour?

@pierre-vigier
Copy link
Owner

Hi,
one of my question is why adding a dependency? what in the old behaviour was incorrect, and is fixed by that?

@Junker
Copy link
Author

Junker commented Mar 29, 2018

Hi. I didn't find anything wrong with old behavior, as you see this is not my commits about $ionicFilterBar, i forked from his fork because some fixes, maybe should bring back old behavior.

@pierre-vigier
Copy link
Owner

Oh, i did miss that, i did not pay attention there were 2 people's commit there, sorry for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants